Re: + v4l-720-alsa-support-for-saa7134-that-should-work-fix.patch added to -mm tree

[Lee Revell <rlrevell@joe-job.com>]

On Mon, 2005-11-07 at 04:26 -0200, Mauro Carvalho Chehab wrote:
> Lee,
> 
> Em Dom, 2005-11-06 às 13:33 -0500, Lee Revell escreveu:
> > On Sun, 2005-11-06 at 00:12 -0800, Andrew Morton wrote:
> > > Well that didn't work.  The problem is that
> > > drivers/media/video/saa7134/saa7134-alsa.c doesn't appear to be wired
> > > up into the build system - it simply doesn't get compiled.
> > > 
> > > Please send a fix against next -mm? 
> > 
> > Also please send all ALSA related patches to
> > alsa-devel@lists.sourceforge.net for review.
> 
> 	I'm sending you enclosed saa7134-alsa patch. To make easier to
> understand, I've merged all stuff. This is highly dependent of the other
> saa7134 parts, since PCI stuff are common to both video and audio
> funcion on this device.
> 	This is meant to replace saa7134-oss (after more tests) that,
> currently, is part of saa7134 module.

OK, a brief review:

 - Why couldn't you use ALSA's DMA API?

 - The DMA must be stopped and started in the trigger callback, not the
prepare callback.

 - If this device lacks a volume control alsa-lib can emulate it in
software, just create a proper /usr/share/alsa/cards/your_card.conf
file.

 - By ALSA convention the acceptable formats, sample rates, etc should
be directly defined in the snd_pcm_hardware_t structure.

 - dev->oss needs to go.

Lee