From: R C <v4l@cerqueira.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: mchehab@brturbo.com.br, linux-kernel@vger.kernel.org,
akpm@osdl.org, video4linux-list@redhat.com, rlrevell@joe-job.com,
alsa-devel@lists.sourceforge.net, nshmyrev@yandex.ru
Subject: Re: [Patch 1/1] V4L (926) Saa7134 alsa can only be autoloaded after saa7134 is active
Date: Tue, 08 Nov 2005 12:07:50 +0000 [thread overview]
Message-ID: <1131451671.2863.4.camel@frolic> (raw)
In-Reply-To: <s5hd5lbnzg6.wl%tiwai@suse.de>
On Tue, 2005-11-08 at 12:36 +0100, Takashi Iwai wrote:
[...]
> Note that "goto done" may
> require the lock again. Also, the succeeding saa7134_dma_stop() is
> superfluous.
>
No, it's not. dma_stop also affects the main saa7134 module, and it's
needed there.
[...]
> @@ -973,18 +963,17 @@ int alsa_card_saa7134_create (struct saa
> > chip->irq = saadev->pci->irq;
> > chip->iobase = pci_resource_start(saadev->pci, 0);
> >
> > - err = request_irq(chip->pci->irq, saa7134_alsa_irq,
> > + err = request_irq(saadev->pci->irq, saa7134_alsa_irq,
> > SA_SHIRQ | SA_INTERRUPT, saadev->name, saadev);
>
> Hmm, still I don't see any call of free_irq() in the driver?
>
It was added to v4l CVS shortly after Mauro sent the last patchset,
should be sent upstream in the next patchset.
[...]
--
RC
next prev parent reply other threads:[~2005-11-08 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-07 20:48 [Patch 1/1] V4L (926) Saa7134 alsa can only be autoloaded after saa7134 is active mchehab
2005-11-08 11:36 ` Takashi Iwai
2005-11-08 12:07 ` R C [this message]
2005-11-08 13:20 ` Takashi Iwai
2005-11-08 21:09 ` R C
2005-11-09 22:59 ` Lee Revell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131451671.2863.4.camel@frolic \
--to=v4l@cerqueira.org \
--cc=akpm@osdl.org \
--cc=alsa-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=nshmyrev@yandex.ru \
--cc=rlrevell@joe-job.com \
--cc=tiwai@suse.de \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox