From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sergei Shtylylov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: PATCH: libata PATA patches
Date: Wed, 09 Nov 2005 15:52:17 +0000 [thread overview]
Message-ID: <1131551537.6540.21.camel@localhost.localdomain> (raw)
In-Reply-To: <4371FA47.1070806@ru.mvista.com>
On Mer, 2005-11-09 at 16:31 +0300, Sergei Shtylylov wrote:
> I found somewhat strange that you check for 0xABCDExxx signature in 32-bit
> PCI config. reg. 0x78 while HighPoint's own drivers read BM reg. 0x90 (i.e.
> PCI config. 0x70) for that. PCI reg. 0x7A is DPLL precision adjust reg. and
> 0x7B is the input clock select and IRQ reg., so it'd be quite strange if the
> BIOS used them for any kind of signature...
Yeah thats a bug. What I get for reading the comments in the old driver
and not double checking against the HPT reference code. Thanks
Alan
prev parent reply other threads:[~2005-11-09 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 14:33 PATCH: libata PATA patches Alan Cox
2005-11-08 14:13 ` Adrian Bunk
2005-11-08 16:46 ` Alan Cox
2005-11-09 13:31 ` Sergei Shtylylov
2005-11-09 15:23 ` Sergei Shtylylov
2005-11-09 15:52 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131551537.6540.21.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox