From: Alex Williamson <alex.williamson@hp.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backup timer for UARTs that lose interrupts
Date: Thu, 10 Nov 2005 06:38:36 -0700 [thread overview]
Message-ID: <1131629916.4471.11.camel@localhost.localdomain> (raw)
In-Reply-To: <20051110104419.GA20693@flint.arm.linux.org.uk>
On Thu, 2005-11-10 at 10:44 +0000, Russell King wrote:
> Ok, would you mind fixing the patch so it isn't screwing up the
> default use of up->timer please? You may notice that this timer
> is already used, and overwriting up->timer.function is a one-way
> process in your patch (which kills off the point of serial8250_timeout).
I return up->timer.function to serial8250_timeout in the polling mode
path of serial8250_startup(). The patch only makes use of up->timer
when it's not already being used for polling and will restore it on the
next startup if the UART is switched to polling. Would you prefer that
I always set up->timer.function to serial8250_timeout on the shutdown
path? Thanks,
Alex
prev parent reply other threads:[~2005-11-10 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 20:27 [PATCH] backup timer for UARTs that lose interrupts Alex Williamson
2005-11-08 23:23 ` Russell King
2005-11-09 0:16 ` Alex Williamson
2005-11-10 10:44 ` Russell King
2005-11-10 13:38 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131629916.4471.11.camel@localhost.localdomain \
--to=alex.williamson@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox