From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Michael Buesch <mbuesch@freenet.de>,
Linus Torvalds <torvalds@osdl.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [2.6 patch] PPC_PREP: remove unneeded exports
Date: Sun, 13 Nov 2005 14:23:29 +1100 [thread overview]
Message-ID: <1131852210.5504.36.camel@gaston> (raw)
In-Reply-To: <20051113012608.GH21448@stusta.de>
On Sun, 2005-11-13 at 02:26 +0100, Adrian Bunk wrote:
> On Sun, Nov 13, 2005 at 09:31:06AM +1100, Benjamin Herrenschmidt wrote:
> >
> > > ucSystemType is a variable that is EXPORT_SYMBOL'ed but never used in
> > > any way.
> > >
> > > _prep_type is a variable that is needlessly EXPORT_SYMBOL'ed.
> >
> > Therse are old PREP stuffs
> >...
>
> Is the patch below OK?
The ucXXX variables should probably go (or at least be unexported) but I
would keep the _prep_type export for now, unless we are certain no
driver and no out of tree stuff neither uses it (hrm... might well be
the case).
In any case, the proper fix is probably to move the EXPORT_SYMBOL() out
of ppc_ksyms, and have it next to the declaration of the variable.
Ben.
next prev parent reply other threads:[~2005-11-13 3:28 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-12 2:24 Linuv 2.6.15-rc1 Linus Torvalds
2005-11-12 8:17 ` [PATCH] Linux 2.6.15-rc1; fix b2c2 dvb undefined symbol Prakash Punnoor
2005-11-12 17:52 ` Linuv 2.6.15-rc1 Michal Piotrowski
2005-11-12 20:45 ` Michael Buesch
2005-11-12 21:00 ` Linus Torvalds
2005-11-12 21:37 ` Michael Buesch
2005-11-12 21:53 ` Adrian Bunk
2005-11-12 21:57 ` Michael Buesch
2005-11-12 22:20 ` Adrian Bunk
2005-11-12 22:31 ` Benjamin Herrenschmidt
2005-11-13 1:26 ` [2.6 patch] PPC_PREP: remove unneeded exports Adrian Bunk
2005-11-13 3:23 ` Benjamin Herrenschmidt [this message]
2005-11-14 19:56 ` Linuv 2.6.15-rc1 Tom Rini
2005-11-12 22:08 ` Olof Johansson
2005-11-12 22:25 ` Benjamin Herrenschmidt
2005-11-12 22:33 ` Michael Buesch
2005-11-13 16:37 ` Kumar Gala
2005-11-13 20:59 ` Benjamin Herrenschmidt
2005-11-15 18:53 ` Olaf Hering
2005-11-14 1:04 ` Jesper Juhl
2005-11-12 22:24 ` Benjamin Herrenschmidt
2005-11-12 23:13 ` asm/delay.h missing on powerpc (was: Re: Linuv 2.6.15-rc1) Michael Buesch
2005-11-13 0:33 ` Benjamin Herrenschmidt
2005-11-13 9:54 ` Michael Buesch
2005-11-12 21:28 ` PowerBook G4 boot failure " Alexey Dobriyan
2005-11-12 22:39 ` Linuv 2.6.15-rc1 John W. Linville
2005-11-12 23:29 ` Jody McIntyre
2005-11-13 9:01 ` Christoph Hellwig
2005-11-13 11:05 ` Jens Axboe
2005-11-16 6:15 ` [patch] new block/ directory comment tidy Coywolf Qi Hunt
2005-11-16 7:48 ` Christoph Hellwig
2005-11-16 7:57 ` Jens Axboe
2005-11-16 8:08 ` Coywolf Qi Hunt
2005-11-16 14:27 ` Jens Axboe
2005-11-14 13:58 ` Linuv 2.6.15-rc1 Alexandre Buisse
2005-11-14 14:32 ` Zilvinas Valinskas
2005-11-14 15:24 ` Mark Lord
2005-11-14 18:25 ` Pekka Enberg
2005-11-14 19:22 ` Alexandre Buisse
2005-11-15 9:05 ` Žilvinas Valinskas
2005-11-14 22:26 ` Bill Davidsen
2005-11-15 9:04 ` Žilvinas Valinskas
2005-11-16 14:32 ` Bill Davidsen
2005-11-14 18:24 ` Pekka Enberg
2005-11-15 0:29 ` Andrew Morton
2005-11-15 10:05 ` Zilvinas Valinskas
2005-11-15 11:56 ` Zilvinas Valinskas
2005-11-15 12:51 ` Pekka Enberg
2005-11-15 13:08 ` Zilvinas Valinskas
2005-11-15 14:00 ` Zilvinas Valinskas
2005-11-16 5:49 ` Zhu Yi
2005-11-16 9:45 ` Zilvinas Valinskas
2005-11-16 10:05 ` Pekka Enberg
2005-11-16 10:37 ` Zilvinas Valinskas
2005-11-16 11:40 ` Zilvinas Valinskas
2005-11-16 12:18 ` Pekka J Enberg
2005-11-16 12:29 ` Zilvinas Valinskas
2005-11-16 13:15 ` Zilvinas Valinskas
2005-11-16 13:33 ` Zilvinas Valinskas
2005-11-16 16:33 ` Pekka Enberg
2005-11-16 18:15 ` Zilvinas Valinskas
2005-11-16 19:55 ` [PATCH] ipw2200: disallow direct scanning when device is down (was: Linuv 2.6.15-rc1) Pekka Enberg
2005-11-16 20:04 ` Alejandro Bonilla
2005-11-17 5:59 ` Zhu Yi
2005-11-16 16:04 ` Linuv 2.6.15-rc1 Linus Torvalds
2005-11-16 9:33 ` Pekka J Enberg
2005-11-16 10:38 ` Zilvinas Valinskas
2005-11-16 12:22 ` Zilvinas Valinskas
2005-11-16 5:49 ` abuisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131852210.5504.36.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mbuesch@freenet.de \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox