From: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
To: Adrian Bunk <bunk@stusta.de>
Cc: video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/media/video/: make code static
Date: Sun, 20 Nov 2005 13:47:23 -0200 [thread overview]
Message-ID: <1132501643.24952.28.camel@localhost> (raw)
In-Reply-To: <20051120024432.GV16060@stusta.de>
Adrian,
Em Dom, 2005-11-20 às 03:44 +0100, Adrian Bunk escreveu:
> This patch makes needlessly global code static.
>
>
> drivers/media/video/bttv-cards.c | 6 +++---
> drivers/media/video/cx25840/cx25840-core.c | 4 ++--
> drivers/media/video/em28xx/em28xx-core.c | 6 +++---
> drivers/media/video/em28xx/em28xx-video.c | 2 +-
> drivers/media/video/saa7127.c | 6 +++---
> drivers/media/video/saa7134/saa7134-alsa.c | 9 +++++----
> drivers/media/video/saa7134/saa7134-oss.c | 4 ++--
> 7 files changed, 19 insertions(+), 18 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Thanks for your patch.
> --- linux-2.6.15-rc1-mm2-full/drivers/media/video/saa7134/saa7134-alsa.c.old 2005-11-20 02:49:12.000000000 +0100
> +++ linux-2.6.15-rc1-mm2-full/drivers/media/video/saa7134/saa7134-alsa.c 2005-11-20 02:58:01.000000000 +0100
> @@ -58,7 +58,7 @@
> module_param_array(index, int, NULL, 0444);
> MODULE_PARM_DESC(index, "Index value for SAA7134 capture interface(s).");
>
> -int position;
> +static int position;
This didn't applied at V4L tree. This flag was removed at the latest
version. We had already a patch including static on some I2C structs and
other trivial fixes.
I'll added your patch with fixes on my tree and send to -mm in the next
V4L patchsets, after the patch that removes position and fixes some
stuff at saa7134-alsa.
Cheers,
Mauro.
next prev parent reply other threads:[~2005-11-20 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-20 2:44 [2.6 patch] drivers/media/video/: make code static Adrian Bunk
2005-11-20 15:47 ` Mauro Carvalho Chehab [this message]
2005-12-01 19:46 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1132501643.24952.28.camel@localhost \
--to=mchehab@brturbo.com.br \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox