public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jörn Dreyer" <j.dreyer@butonic.de>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] nfsroot.c, kernel 2.6.14.3, do not silently stop parsing on an unknown option
Date: Mon, 28 Nov 2005 15:32:04 +0100	[thread overview]
Message-ID: <1133188324.9663.28.camel@localhost> (raw)

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hello,


I think it would be helpful if the kernel did not silently stop parsing
nfs options, but instead warned about any he does not recognize. The
attached patch adds one printk to do just that.
It took me a couple of hours to find my configuration mistake - it is a
trivial patch, nevertheless, I would like to see the patch included to
save others the time ...

Sincerely

Jörn Dreyer


[-- Attachment #2: nfswarning.patch --]
[-- Type: text/x-patch, Size: 464 bytes --]

--- linux-2.6.14.3/fs/nfs/nfsroot.c     2005-11-24 23:10:21.000000000 +0100
+++ linux/fs/nfs/nfsroot.c      2005-11-28 14:50:59.223111632 +0100
@@ -276,6 +277,7 @@
                                nfs_data.flags |= NFS_MOUNT_NOACL;
                                break;
                        default :
+                               printk(KERN_WARNING "Root-NFS: unknown option: %s\n", p);
                                return 0;
                }
        }

                 reply	other threads:[~2005-11-28 14:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1133188324.9663.28.camel@localhost \
    --to=j.dreyer@butonic.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox