public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/4] stack overflow safe kdump (i386) - do_nmi
@ 2005-11-28 18:00 Fernando Luis Vazquez Cao
  0 siblings, 0 replies; only message in thread
From: Fernando Luis Vazquez Cao @ 2005-11-28 18:00 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: linux-kernel, fastboot

crash_nmi_callback is called right after a system crash which might have
caused by stack overflow, thus smp_processor_id should not be trusted.
Use the safe replacement safe_smp_processor_id.

---

diff -urNp linux-2.6.15-rc2/arch/i386/kernel/traps.c
linux-2.6.15-rc2-sov/arch/i386/kernel/traps.c
--- linux-2.6.15-rc2/arch/i386/kernel/traps.c	2005-11-29
01:46:34.000000000 +0900
+++ linux-2.6.15-rc2-sov/arch/i386/kernel/traps.c	2005-11-29
01:52:17.000000000 +0900
@@ -648,7 +648,7 @@ fastcall void do_nmi(struct pt_regs * re
 
 	nmi_enter();
 
-	cpu = smp_processor_id();
+	cpu = safe_smp_processor_id();
 
 #ifdef CONFIG_HOTPLUG_CPU
 	if (!cpu_online(cpu)) {



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-11-28 18:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-28 18:00 [PATCH 3/4] stack overflow safe kdump (i386) - do_nmi Fernando Luis Vazquez Cao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox