From: Rusty Russell <rusty@rustcorp.com.au>
To: "Tomar, Nagendra" <nagendra_tomar@adaptec.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Why does insmod _not_ check for symbol redefinition ??
Date: Thu, 01 Dec 2005 11:57:09 +1100 [thread overview]
Message-ID: <1133398629.8128.10.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.44.0511251029150.18002-100000@localhost.localdomain>
On Fri, 2005-11-25 at 10:45 +0530, Nagendra Singh Tomar wrote:
> Did'nt get any response to this one, so sending it again.
>
> Can any of the module subsystem authors tell, why they have decided to
> allow loading a kernel module having an EXPORTed symbol with the same name
> as an EXPORTed symbol in kernel proper. The safest thing would be to
> disallow module loading in this case, giving a "Symbol redefinition"
> error.
> Allowing the module load will lead to overriding kernel functions
> which will affect modules loaded in future, that reference those
> functions. Overall, it can have bad effects of varying severity.
Sure. It was due to minimalism. If you override a symbol it's
undefined behavior. It should be fairly simple to add a check that
noone overrides a symbol. We didn't bother checking for it because it
wasn't clear that it was problematic.
Hope that clarifies,
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
next prev parent reply other threads:[~2005-12-01 0:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c216304e0511242042h30fccd74ic2b1d5b237e2afc0@mail.gmail.com>
2005-11-25 5:15 ` Why does insmod _not_ check for symbol redefinition ?? Nagendra Singh Tomar
2005-12-01 0:57 ` Rusty Russell [this message]
2005-12-01 4:12 ` Nagendra Singh Tomar
2005-12-01 5:25 ` Coywolf Qi Hunt
2005-11-25 15:51 Parag Warudkar
-- strict thread matches above, loose matches on Subject: below --
2005-11-24 7:54 Nagendra Singh Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133398629.8128.10.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=nagendra_tomar@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox