public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, francis_moreau2000@yahoo.fr,
	Paul Jackson <pj@sgi.com>,
	"linux-os (Dick Johnson)" <linux-os@analogic.com>,
	Bill Davidsen <davidsen@tmr.com>
Subject: Re: Use enum to declare errno values
Date: Fri, 02 Dec 2005 12:51:00 -0500	[thread overview]
Message-ID: <1133545860.32583.87.camel@localhost.localdomain> (raw)
In-Reply-To: <2cd57c900512020907h4be23519q@mail.gmail.com>

I'm going to regret jumping in on this.

On Sat, 2005-12-03 at 01:07 +0800, Coywolf Qi Hunt wrote:
> 2005/12/3, Bill Davidsen <davidsen@tmr.com>:
> > Coywolf Qi Hunt wrote:
> >
> > > This is a reason why enums are worse than #defines.
> > >
> > > Unlike in other languages, C enum is not much useful in practices.
> >
> > Actually they are highly useful if you know how to use them. They allow
> > type checking, have auto increment, and are part of the language instead
> >   of a feature of the preprocessor.
> 
> Yes, I know type checking and auto increment. But they are not
> worthwhile, at least not for serious C programming. No, I don't know
> how to use them comfortably.

Hmm, I like to use a lot of both enums and macros (defines).  I use
defines mostly for general constants and emums for enumerations.
Although it can be argued that errno should be enums, I would prefer
them as macros.  Especially since they then can be used in asm. (.S
files).

I seldom use enums for kernel programming though.  I use it just to
define a list of numbers where I don't care what their value is (usually
for transition states).  I use defines when I do.  Because errno does
depend on the value (for glibc to figure them out too) then I think
defines are better.

But in user space programming I use enums more often than defines,
because gdb can convert the number into a name.  So instead of seeing
x=0x1234 I see x=FOO.

-- Steve




  reply	other threads:[~2005-12-02 17:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-23 13:24 Use enum to declare errno values moreau francis
2005-11-23 14:19 ` linux-os (Dick Johnson)
2005-11-23 14:24   ` Denis Vlasenko
2005-11-23 15:00     ` linux-os (Dick Johnson)
2005-11-24  7:19       ` Denis Vlasenko
2005-11-24  7:30         ` Paul Jackson
2005-11-24  7:37           ` Paul Jackson
2005-12-01 20:01           ` linux-os (Dick Johnson)
2005-12-02  6:49             ` Denis Vlasenko
2005-12-02  9:27               ` Coywolf Qi Hunt
2005-12-02 12:07                 ` Denis Vlasenko
2005-12-02 12:18                 ` Pekka Enberg
2005-12-02 12:56                   ` Coywolf Qi Hunt
2005-12-02 13:20                     ` Denis Vlasenko
2005-12-02 13:34                     ` Pekka Enberg
2005-12-02 16:02                     ` Bill Davidsen
2005-12-02 16:32                       ` Coywolf Qi Hunt
2005-12-02 16:56                       ` Vadim Lobanov
2005-12-04 13:10                         ` Denis Vlasenko
2005-12-02 16:15                 ` Bill Davidsen
2005-12-02 17:07                   ` Coywolf Qi Hunt
2005-12-02 17:51                     ` Steven Rostedt [this message]
2005-12-02 18:15                     ` Bill Davidsen
2005-12-02 18:30                     ` Horst von Brand
2005-11-23 14:27 ` Denis Vlasenko
2005-11-23 14:31 ` Denis Vlasenko
2005-11-23 15:15   ` Alan Cox
2005-11-23 15:44     ` moreau francis
2005-11-23 15:55       ` Nikita Danilov
2005-11-23 16:05         ` moreau francis
2005-11-23 16:24           ` Nikita Danilov
2005-11-23 16:42             ` moreau francis
2005-11-23 16:54               ` Nikita Danilov
2005-11-24  7:22       ` Denis Vlasenko
2005-11-23 17:35     ` Bill Davidsen
2005-11-24  9:43   ` Giuliano Pochini
2005-11-28 23:19     ` Bill Davidsen
2005-11-24 17:11 ` Ben Pfaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1133545860.32583.87.camel@localhost.localdomain \
    --to=rostedt@goodmis.org \
    --cc=coywolf@gmail.com \
    --cc=davidsen@tmr.com \
    --cc=francis_moreau2000@yahoo.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-os@analogic.com \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox