public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Revell <rlrevell@joe-job.com>
To: Dave Jones <davej@redhat.com>
Cc: Andi Kleen <ak@suse.de>,
	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
	Andrew Morton <akpm@osdl.org>, cpufreq <cpufreq@www.linux.org.uk>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] CPU frequency display in /proc/cpuinfo
Date: Mon, 05 Dec 2005 10:32:27 -0500	[thread overview]
Message-ID: <1133796748.21641.8.camel@mindpipe> (raw)
In-Reply-To: <20051205011611.GA12664@redhat.com>

On Sun, 2005-12-04 at 20:16 -0500, Dave Jones wrote:
> On Sun, Dec 04, 2005 at 02:49:26PM -0500, Lee Revell wrote:
>  > On Sun, 2005-12-04 at 19:32 +0100, Andi Kleen wrote:
>  > > On Sun, Dec 04, 2005 at 05:43:35PM +0100, Dominik Brodowski wrote:
>  > > > On Fri, Dec 02, 2005 at 10:43:20AM -0800, Venkatesh Pallipadi wrote:
>  > > > > The patch below changes this to:
>  > > > > Show the last known frequency of the particular CPU, when cpufreq is present. If
>  > > > > cpu doesnot support changing of frequency through cpufreq, then boot frequency 
>  > > > > will be shown. The patch affects i386, x86_64 and ia64 architectures.
>  > > > 
>  > > > Looks good to me -- however, might this affect userspace cpufreq tools? I'd
>  > > 
>  > > They normally use /sys anyways.
>  > 
>  > Wrong, lots of userspace programs that need to know the CPU speed get it
>  > from /proc/cpuinfo.  It would be nice if there were a better API.
> 
> I can't think of a single valid reason why a program would want
> to know the MHz rating of a CPU. Given that it's a) approximate,
> b) subject to change due to power management, c) completely nonsensical
> across CPU vendors, and d) only one of many variables regarding CPU
> performance, any program that bases any decision on the values found
> by parsing that field of /proc/cpuinfo is utterly broken beyond belief.

JACK needs to know the CPU speed in order to be able to use RDTSC for
timing.  Yes that might be "broken" but gettimeofday() is simply not
fast enough for our use, we can't afford the overhead of thousands of
system calls per second.  And until recently 99.999% of desktop machines
had a monotonic TSC so this worked very well.

I don't see how people can say that gettimeofday() is as fast as the
hardware allows, when gettimeofday() just uses RDTSC to interpolate
since the last timer tick but is ~40x slower than RDTSC on my system.

Lee


  parent reply	other threads:[~2005-12-05 15:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-02 18:13 [PATCH] CPU frequency display in /proc/cpuinfo Venkatesh Pallipadi
2005-12-02 18:19 ` Andi Kleen
2005-12-02 18:43   ` Venkatesh Pallipadi
2005-12-04 16:43     ` Dominik Brodowski
2005-12-04 18:32       ` Andi Kleen
2005-12-04 19:49         ` Lee Revell
2005-12-04 20:13           ` Andi Kleen
2005-12-04 21:01           ` Horst von Brand
2005-12-05  1:16           ` Dave Jones
2005-12-05 13:02             ` Erik Mouw
2005-12-05 17:25               ` Dave Jones
2005-12-05 17:27                 ` Lee Revell
2005-12-06 11:13                 ` Erik Mouw
2005-12-06 16:56                   ` Dave Jones
2005-12-06 17:35                     ` Erik Mouw
2005-12-05 15:32             ` Lee Revell [this message]
2005-12-05 18:36               ` Andi Kleen
2005-12-05 15:59             ` Mark Lord
2005-12-05 17:26               ` Dave Jones
2005-12-05 16:29             ` Avi Kivity
2005-12-05 16:46               ` linux-os (Dick Johnson)
2005-12-05 17:27               ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1133796748.21641.8.camel@mindpipe \
    --to=rlrevell@joe-job.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=cpufreq@www.linux.org.uk \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox