Re: Two module-init-

[Richard Purdie <rpurdie@rpsys.net>]

On Sun, 2005-12-04 at 21:24 +1100, Rusty Russell wrote:
> On Fri, 2005-12-02 at 23:28 -0500, Dmitry Torokhov wrote:
> > On Friday 02 December 2005 23:19, Dmitry Torokhov wrote:
> > > On Thursday 01 December 2005 19:12, Rusty Russell wrote:
> > > > Meanwhile, as noone seems to use swbit in struct input_device_id,
> > > > perhaps we can remove it for 2.6.15?
> > > > 
> > > 
> > > Please take a look at drivers/input/keyboard/corgikbd.c
> > > 
> > 
> > What I meant we do use EV_SW in the drivers and so it sould be part
> > of input_device_id. Nobody uses ffbit or sndbit either and still
> > they are present...
> 
> Sure.  BUT it will break current users.  I'm suggesting we jerk that
> field out for 2.6.15, and reintroduce it for >= 2.6.16, when we can (1)
> ensure everyone has a fixed module-init tools, or (2) make sure everyone
> is using the module alias stuff, or both.
> 
> It seems the simplest solution, surely?

The two users of EV_SW I'm aware of are corgikbd.c and spitzkbd.c.
Speaking as the maintainer of the kernel builds for the main users of
Zaurus 2.6 kernels, I can safely say that those two drivers are always
likely to be compiled into a kernel (not modules) and therefore this is
unlikely to upset anyone from a technical point of view. I keep out of
politics ;-)

Richard