From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Shaohua Li <shaohua.li@intel.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
linux-ide <linux-ide@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>, pavel <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>, akpm <akpm@osdl.org>
Subject: Re: [RFC]add ACPI hooks for IDE suspend/resume
Date: Wed, 07 Dec 2005 22:35:16 +0000 [thread overview]
Message-ID: <1133994916.544.102.camel@localhost.localdomain> (raw)
In-Reply-To: <58cb370e0512071115i3dbb741aqda7f98a97221d99b@mail.gmail.com>
On Mer, 2005-12-07 at 20:15 +0100, Bartlomiej Zolnierkiewicz wrote:
> PS1 Please don't use taskfile_lib_get_identify(), drive->id
> should contain valid ID - if it doesn't it is a BUG.
If someone swapped the drive while suspended that isnt true. OTOH I'm
not sure what the hell you'd do if that was the case and you are using
drivers/ide right now.
> PS2 Have you seen libata ACPI patches by Randy?
> Maybe some of the code dealing with ACPI can be put to
> <linux/ata.h> and be shared between IDE and libata drivers?
Definitely a good idea. Also exposing the methods will be useful for
producing a proper libata 'ata_acpi' driver that does the best it can
using ACPI methods for tuning unknown hardware.
next prev parent reply other threads:[~2005-12-07 22:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 6:10 [RFC]add ACPI hooks for IDE suspend/resume Shaohua Li
2005-12-06 22:20 ` Matthew Garrett
2005-12-06 22:50 ` Alan Cox
2005-12-07 8:17 ` Bartlomiej Zolnierkiewicz
2005-12-07 13:14 ` Matthew Garrett
2005-12-07 14:19 ` Bartlomiej Zolnierkiewicz
2005-12-07 14:26 ` Bartlomiej Zolnierkiewicz
2005-12-07 14:34 ` Matthew Garrett
2005-12-07 14:33 ` Matthew Garrett
2005-12-07 14:45 ` Bartlomiej Zolnierkiewicz
2005-12-07 14:58 ` Matthew Garrett
2005-12-07 15:44 ` Bartlomiej Zolnierkiewicz
2005-12-07 15:53 ` Matthew Garrett
2005-12-07 15:41 ` Alan Cox
2005-12-07 15:49 ` Bartlomiej Zolnierkiewicz
2005-12-07 1:22 ` Shaohua Li
2005-12-07 19:15 ` Bartlomiej Zolnierkiewicz
2005-12-07 22:35 ` Alan Cox [this message]
2005-12-07 22:42 ` Bartlomiej Zolnierkiewicz
2005-12-07 22:43 ` Pavel Machek
2005-12-07 22:48 ` Matthew Garrett
2005-12-07 0:11 ` Randy.Dunlap
2005-12-07 1:15 ` Shaohua Li
-- strict thread matches above, loose matches on Subject: below --
2005-12-07 21:58 Li, Shaohua
2005-12-07 23:19 Li, Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133994916.544.102.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=bzolnier@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pavel@ucw.cz \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox