From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Philippe De Muyter <phdm@macqel.be>
Cc: linux-kernel@vger.kernel.org,
Linux and Kernel Video <video4linux-list@redhat.com>
Subject: Re: [PATCH 2.6.15-rc5] media/video/bttv : enhance ioctl debug
Date: Mon, 12 Dec 2005 08:36:03 -0200 [thread overview]
Message-ID: <1134383763.18903.37.camel@localhost> (raw)
In-Reply-To: <200512082105.jB8L5xW12712@mail.macqel.be>
Em Qui, 2005-12-08 às 22:05 +0100, Philippe De Muyter escreveu:
> This patch adds the current process name in the media/video/bttv ioctl debug.
Philippe,
I'm in doubt about the relevance of this patch. Why do you think it is
important to have process name at ioctl debug?
PS.: Please address these patches to V4L Mailing List.
>
> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
>
> ---
>
> --- linux/drivers/media/video/bttv-driver.c.orig 2005-08-29 01:41:01.000000000 +0200
> +++ linux/drivers/media/video/bttv-driver.c 2005-12-08 20:59:45.000000000 +0100
> @@ -2181,19 +2182,19 @@ static int bttv_do_ioctl(struct inode *i
> int retval = 0;
>
> if (bttv_debug > 1) {
> + printk("bttv%d: %s: ioctl 0x%x ", btv->c.nr, current->comm,
> + cmd);
> switch (_IOC_TYPE(cmd)) {
> case 'v':
> - printk("bttv%d: ioctl 0x%x (v4l1, VIDIOC%s)\n",
> - btv->c.nr, cmd, (_IOC_NR(cmd) < V4L1_IOCTLS) ?
> + printk("(v4l1, VIDIOC%s)\n",
> + (_IOC_NR(cmd) < V4L1_IOCTLS) ?
> v4l1_ioctls[_IOC_NR(cmd)] : "???");
> break;
> case 'V':
> - printk("bttv%d: ioctl 0x%x (v4l2, %s)\n",
> - btv->c.nr, cmd, v4l2_ioctl_names[_IOC_NR(cmd)]);
> + printk("(v4l2, %s)\n", v4l2_ioctl_names[_IOC_NR(cmd)]);
> break;
> default:
> - printk("bttv%d: ioctl 0x%x (???)\n",
> - btv->c.nr, cmd);
> + printk("(???)\n");
> }
> }
> if (btv->errors)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2005-12-12 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 21:05 [PATCH 2.6.15-rc5] media/video/bttv : enhance ioctl debug Philippe De Muyter
2005-12-12 10:36 ` Mauro Carvalho Chehab [this message]
2005-12-14 16:42 ` Philippe De Muyter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134383763.18903.37.camel@localhost \
--to=mchehab@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phdm@macqel.be \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox