From: James Bottomley <James.Bottomley@SteelEye.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Brian King <brking@us.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>, Jens Axboe <axboe@suse.de>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: Memory corruption & SCSI in 2.6.15
Date: Mon, 12 Dec 2005 14:13:51 -0600 [thread overview]
Message-ID: <1134418432.9994.32.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.64.0512121149360.15597@g5.osdl.org>
On Mon, 2005-12-12 at 11:55 -0800, Linus Torvalds wrote:
> Indeed, that looks pretty subtle.
>
> James: Brian's patch looks obviously correct to me (scsi_alloc_sdev() will
> have called scsi_sysfs_device_initialize() which will set up the release
> function to free the queue).
Yes it does ... I'll put it in the rc-fixes tree.
> This code has been like that forever, though, which makes me wonder. Can
> anybody see what has changed to make the bug trigger? Or is there
> something I'm missing?
The trigger, based on the failure path has to be a slave_alloc failure
of an underlying driver (which isn't that common). This may not be
visible in the dmesg traces if anyone has one, because reporting the
condition is up to the driver.
James
next prev parent reply other threads:[~2005-12-12 20:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 7:13 Memory corruption & SCSI in 2.6.15 Benjamin Herrenschmidt
2005-12-12 17:17 ` Linus Torvalds
2005-12-12 18:32 ` Nathan Lynch
2005-12-12 18:51 ` Jens Axboe
2005-12-12 20:33 ` Benjamin Herrenschmidt
2005-12-12 20:51 ` Linus Torvalds
2005-12-12 20:57 ` Benjamin Herrenschmidt
2005-12-13 0:11 ` Benjamin Herrenschmidt
2005-12-12 18:09 ` Jens Axboe
2005-12-12 19:05 ` Brian King
2005-12-12 19:55 ` Linus Torvalds
2005-12-12 20:13 ` James Bottomley [this message]
2005-12-12 20:01 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134418432.9994.32.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=brking@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox