From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: rmk@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Serial: bug in 8250.c when handling PCI or other level triggers
Date: Wed, 14 Dec 2005 15:23:23 +0000 [thread overview]
Message-ID: <1134573803.25663.35.camel@localhost.localdomain> (raw)
The receive_chars function is designed to handle the case where the port
is jammed full on by aborting after 256 characters in one IRQ.
Unfortunately the author of this code forgot that some systems are level
triggered. On these systems the IRQ simply gets invoked again and the
count loop just makes the problem take longer to clear.
In the non level case it appears that a jam could leave the IRQ jammed
forever and ignored - the remaining bytes never appearing.
As far as I can see the code would actually need to clear the interrupt
enable and then restore it on a timer event or similar in order to get
the intended effect.
Alan
next reply other threads:[~2005-12-14 15:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 15:23 Alan Cox [this message]
2005-12-14 16:07 ` Serial: bug in 8250.c when handling PCI or other level triggers Meelis Roos
2005-12-14 17:24 ` Russell King
2005-12-14 18:43 ` Meelis Roos
2005-12-21 15:24 ` Russell King
2005-12-21 20:33 ` Meelis Roos
2005-12-21 22:15 ` Russell King
2005-12-22 10:35 ` Meelis Roos
2005-12-22 13:07 ` Russell King
2005-12-22 13:19 ` Meelis Roos
2005-12-23 9:20 ` Meelis Roos
2005-12-23 9:33 ` Russell King
2005-12-23 10:05 ` Meelis Roos
2005-12-23 10:41 ` Russell King
2005-12-27 13:54 ` Meelis Roos
2005-12-28 19:55 ` Russell King
2005-12-29 8:11 ` Meelis Roos
2006-01-08 23:24 ` Antonio Vargas
2006-01-09 8:54 ` Russell King
2005-12-14 22:29 ` Alan Cox
2005-12-15 19:00 ` Stuart MacDonald
2005-12-14 16:55 ` Russell King
2005-12-14 19:08 ` Alan Cox
2005-12-14 19:55 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134573803.25663.35.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox