Re: [PATCH 26/28] nios2: fix timer initcall return value

Ley Foon Tan
2016-10-24T00:54:56Z

On Tue, Oct 18, 2016 at 6:16 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> When called more than twice, the nios2_time_init() function
> return an uninitialized value, as detected by gcc -Wmaybe-uninitialized
>
> arch/nios2/kernel/time.c: warning: 'ret' may be used uninitialized in this function
>
> This makes it return '0' here, matching the comment above the
> function.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/nios2/kernel/time.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/nios2/kernel/time.c b/arch/nios2/kernel/time.c
> index d9563dd..746bf5c 100644
> --- a/arch/nios2/kernel/time.c
> +++ b/arch/nios2/kernel/time.c
> @@ -324,6 +324,7 @@ static int __init nios2_time_init(struct device_node *timer)
> ret = nios2_clocksource_init(timer);
> break;
> default:
> + ret = 0;
> break;
> }
Acked-by: Ley Foon Tan <lftan@altera.com>