Re: [RFC] [PATCH] Add memcpy32 function

Christoph Hellwig
2005-12-23T17:42:34Z

On Fri, Dec 23, 2005 at 11:16:28AM -0600, Matt Mackall wrote:
> > io.h is a very generic sounding name for something that just houses
> > a memcpy variant. What's wrong with calling a spade a spade,
> > and using memcpy32.h ?
>
> I think it belongs in string.h alongside memcpy, just for tradition's
> sake. I don't think it belongs in a file named io.h, as it probably
> has uses beyond I/O.

Actually I think memcpy32 is not the thing pathscale wants. They want
memcpy_{to,from}_io32, because memcpy32 wouldn't be allowed to operate
on I/O mapped memory. I'd say back to the drawingboard.

And to pathscale: please get your driver __iomem and endianess annotated
before sending out further core patches, I'm pretty sure getting those
things fixed will shed some light on the actual requirements.