Re: [RFC] [PATCH] Add memcpy32 function

Dave Jones
2005-12-23T02:50:07Z

On Thu, Dec 22, 2005 at 05:35:59PM -0800, Bryan O'Sullivan wrote:
> In response to the comments that followed Roland Dreier posting our
> InfiniPath driver for review last week, we've been making some cleanups
> to our driver code.
>
> As our chip requires 32-bit accesses, we need a copy function that
> guarantees operating in such terms. It was suggested that we make this
> generic, with arch-specific optimised versions.
>
> This patch introduces the generic copy routine, memcpy32. At Andrew's
> suggestion, I've put it in a new header file, include/linux/io.h, which
> I've styled after include/linux/string.h.

io.h is a very generic sounding name for something that just houses
a memcpy variant. What's wrong with calling a spade a spade,
and using memcpy32.h ?

Dave