From: Lee Revell <rlrevell@joe-job.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org,
Hirokazu Takata <takata@linux-m32r.org>
Subject: Re: [WTF?] sys_tas() on m32r
Date: Fri, 23 Dec 2005 14:10:34 -0500 [thread overview]
Message-ID: <1135365035.22177.17.camel@mindpipe> (raw)
In-Reply-To: <20051223055526.bc1a4044.akpm@osdl.org>
On Fri, 2005-12-23 at 05:55 -0800, Andrew Morton wrote:
> Al Viro <viro@ftp.linux.org.uk> wrote:
> >
> > asmlinkage int sys_tas(int *addr)
> > {
> > int oldval;
> > unsigned long flags;
> >
> > if (!access_ok(VERIFY_WRITE, addr, sizeof (int)))
> > return -EFAULT;
> > local_irq_save(flags);
> > oldval = *addr;
> > if (!oldval)
> > *addr = 1;
> > local_irq_restore(flags);
> > return oldval;
> > }
> > in arch/m32r/kernel/sys_m32r.c. Trivial oops *AND* ability to trigger
> > IO with interrupts disabled.
>
> Yeah. I pointed this out to Takata in October last year and then promptly
> forgot about it. It's rather amazing that this code (which appears to be in
> live use in linuxthreads) hasn't generated oopses.
No one uses LinuxThreads anymore?
Even the oldest of the old (Debian stable) have moved to NPTL.
Lee
next prev parent reply other threads:[~2005-12-23 19:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-23 6:15 [WTF?] sys_tas() on m32r Al Viro
2005-12-23 7:50 ` liyu
2005-12-23 7:54 ` Al Viro
2005-12-23 13:55 ` Andrew Morton
2005-12-23 19:10 ` Lee Revell [this message]
2005-12-27 6:36 ` Hirokazu Takata
2005-12-27 9:34 ` Jesper Juhl
2005-12-27 5:27 ` Hirokazu Takata
2005-12-27 13:22 ` Andrew Morton
2005-12-28 0:36 ` Hirokazu Takata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135365035.22177.17.camel@mindpipe \
--to=rlrevell@joe-job.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=takata@linux-m32r.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox