public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Revell <rlrevell@joe-job.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: "Rickard E. (Rik) Faith" <faith@redhat.com>
Subject: kernel/auditsc.c bug
Date: Fri, 23 Dec 2005 22:17:19 -0500	[thread overview]
Message-ID: <1135394240.22177.94.camel@mindpipe> (raw)

gcc 4.0.2 complains that state is (not "may be", is) used initialized on
line 607:

605         list_for_each_entry_rcu(e, &audit_filter_list[AUDIT_FILTER_USER], list) {
606                 if (audit_filter_user_rules(cb, &e->rule, &state)) {
607                         if (state == AUDIT_DISABLED)
608                                 ret = 0;
609                         break;
610                 }

AFAICT state will always have been initialized if
audit_filter_user_rules() returns nonzero:

590         switch (rule->action) {
591         case AUDIT_NEVER:    *state = AUDIT_DISABLED;       break;
592         case AUDIT_POSSIBLE: *state = AUDIT_BUILD_CONTEXT;  break;
593         case AUDIT_ALWAYS:   *state = AUDIT_RECORD_CONTEXT; break;
594         }
595         return 1;

Is GCC correct that this is a bug (no default case in the switch
statement)?

Lee


             reply	other threads:[~2005-12-24  3:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-24  3:17 Lee Revell [this message]
2005-12-24  3:28 ` kernel/auditsc.c bug Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1135394240.22177.94.camel@mindpipe \
    --to=rlrevell@joe-job.com \
    --cc=faith@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox