public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Bryan O'Sullivan" <bos@pathscale.com>
To: Andreas Kleen <ak@suse.de>
Cc: Matt Mackall <mpm@selenic.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH] Add memcpy32 function
Date: Wed, 28 Dec 2005 10:11:43 -0800	[thread overview]
Message-ID: <1135793503.1527.125.camel@serpentine.pathscale.com> (raw)
In-Reply-To: <1880308.1135792235045.SLOX.WebMail.wwwrun@imap-dhs.suse.de>

On Wed, 2005-12-28 at 18:50 +0100, Andreas Kleen wrote:

> Ok thanks. And do you have numbers that show that the assembly
> function with rep ; movsl actually  improves performance over C?

I'll see if I can ferret some numbers out.  If not, I'll generate them,
but it will take me a day or so.  I'm pretty sure it makes a difference
of tens to hundreds of nanoseconds, which in our case is very
significant (we measure some of our user-level performance in increments
of 10ns, very repeatably).

> If the assembly is not really faster I would recommend you just use a
> writel()
> loop in the driver instead of adding this very special purpose function
> everywhere.

Yeah, clearly if there's no difference, it's not worth the trouble.

	<b


  reply	other threads:[~2005-12-28 18:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-23  1:35 [RFC] [PATCH] Add memcpy32 function Bryan O'Sullivan
2005-12-23  2:49 ` Dave Jones
2005-12-23 17:16   ` Matt Mackall
2005-12-23 17:42     ` Christoph Hellwig
2005-12-23 18:14       ` Matt Mackall
2005-12-23 23:50       ` Bryan O'Sullivan
2005-12-28 11:01 ` Andi Kleen
2005-12-28 15:00   ` Bryan O'Sullivan
2005-12-28 17:50     ` Andreas Kleen
2005-12-28 18:11       ` Bryan O'Sullivan [this message]
2005-12-28 18:22         ` Andreas Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1135793503.1527.125.camel@serpentine.pathscale.com \
    --to=bos@pathscale.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox