From: Steven Rostedt <rostedt@goodmis.org>
To: Florian Schmidt <mista.tapas@gmx.net>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.15-rt1
Date: Tue, 03 Jan 2006 13:56:40 -0500 [thread overview]
Message-ID: <1136314600.6039.174.camel@localhost.localdomain> (raw)
In-Reply-To: <1136313652.6039.171.camel@localhost.localdomain>
On Tue, 2006-01-03 at 13:40 -0500, Steven Rostedt wrote:
[...]
> Ingo, I guess we have a problem. There must be a reason not to hold
> the rtc_lock and call the {add,mod,del}_timer functions, but your change
> only makes the race condition less likely to happen, and not prevent it.
> The attached program run on an SMP machine will eventually trigger the
> race.
>
> $ gcc -o rtc_ioctl rtc_ioctl.c -lpthread
> $ while : ; do ./rtc_ioctl ; done
[...]
> Should we create another lock to protect only the {add,mod,del}_timer?
> Like the following patch?
Well, with the patch, the above program has been running for over ten
minutes without the race occurring. Without the patch, the race happens
in about one minute or less.
-- Steve
next prev parent reply other threads:[~2006-01-03 18:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-03 9:47 2.6.15-rt1 Ingo Molnar
2006-01-03 11:21 ` 2.6.15-rt1 Michal Piotrowski
2006-01-03 11:27 ` 2.6.15-rt1 Ingo Molnar
2006-01-03 11:34 ` 2.6.15-rt1 Michal Piotrowski
2006-01-03 14:33 ` 2.6.15-rt1 Florian Schmidt
2006-01-03 15:13 ` 2.6.15-rt1 Florian Schmidt
2006-01-03 18:40 ` 2.6.15-rt1 Steven Rostedt
2006-01-03 18:56 ` Steven Rostedt [this message]
2006-01-04 0:01 ` 2.6.15-rt1 Florian Schmidt
2006-01-04 0:24 ` 2.6.15-rt1 Steven Rostedt
2006-01-04 14:31 ` 2.6.15-rt1 Steven Rostedt
2006-01-03 23:12 ` 2.6.15-rt1 David Brown
2006-01-03 23:29 ` 2.6.15-rt1 David Brown
2006-01-04 2:24 ` 2.6.15-rt1 YOSHIFUJI Hideaki / 吉藤英明
2006-01-04 7:16 ` 2.6.15-rt1 David Brown
2006-01-04 7:43 ` 2.6.15-rt1 YOSHIFUJI Hideaki / 吉藤英明
2006-01-04 7:50 ` 2.6.15-rt1 David Brown
2006-01-04 21:01 ` 2.6.15-rt1 Willy Tarreau
2006-01-05 20:52 ` 2.6.15-rt1 James Cloos
2006-01-05 21:00 ` 2.6.15-rt1 David Brown
2006-01-10 22:17 ` 2.6.15-rt1 Esben Stien
2006-01-11 3:09 ` 2.6.15-rt1 Steven Rostedt
2006-01-11 10:16 ` 2.6.15-rt1 Esben Stien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1136314600.6039.174.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mista.tapas@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox