From: Ben Collins <ben.collins@ubuntu.com>
To: Kristian Mueller <kernel@mput.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's
Date: Thu, 05 Jan 2006 09:17:15 -0500 [thread overview]
Message-ID: <1136470635.4430.52.camel@grayson> (raw)
In-Reply-To: <1136403259.14273.17.camel@pismo>
On Thu, 2006-01-05 at 03:34 +0800, Kristian Mueller wrote:
> Hi Ben
>
> On Mi, 2006-01-04 at 17:01 -0500, Ben Collins wrote:
> > Basically completes what's already in the rest of the driver.
> > sleep_in_progress is only defined for pm+ppc32.
> >
> > Signed-off-by: Ben Collins <bcollins@ubuntu.com>
>
> We've already found a different solution to this in the Linuxppc-dev
> list.
>
> See:
> http://patchwork.ozlabs.org/linuxppc/patch?id=3737
That patch makes no sense. It just moves the variable out of the ifdef,
but if CONFIG_PM or CONFIG_PPC32 is not enabled, then the variable never
gets modified, and so is always 0. Why not just wrap all the code that
uses it (like my patch did)?
--
Ben Collins <ben.collins@ubuntu.com>
Developer
Ubuntu Linux
next prev parent reply other threads:[~2006-01-05 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 22:01 [PATCH 12/15] via-pmu: Wrap some uses of sleep_in_progress with proper ifdef's Ben Collins
2006-01-04 19:34 ` Kristian Mueller
2006-01-05 14:17 ` Ben Collins [this message]
2006-01-05 17:22 ` Kristian Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1136470635.4430.52.camel@grayson \
--to=ben.collins@ubuntu.com \
--cc=kernel@mput.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox