From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: Platform device matching, & weird strncmp usage
Date: Fri, 06 Jan 2006 17:04:17 +1100 [thread overview]
Message-ID: <1136527457.4840.123.camel@localhost.localdomain> (raw)
In-Reply-To: <1136527179.4840.120.camel@localhost.localdomain>
On Fri, 2006-01-06 at 16:59 +1100, Benjamin Herrenschmidt wrote:
> Hi !
>
> In 2.6.15, platform device matching works according to this comment in
> the code, or rather are supposed to:
.../...
Just in case my analysis is correct, here's an untested fix:
---
Platform device matching doesn't work when an "id" is used.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
--- linux-work.orig/drivers/base/platform.c 2005-11-24 17:18:43.000000000 +1100
+++ linux-work/drivers/base/platform.c 2006-01-06 16:59:59.000000000 +1100
@@ -447,7 +447,8 @@ static int platform_match(struct device
{
struct platform_device *pdev = container_of(dev, struct platform_device, dev);
- return (strncmp(pdev->name, drv->name, BUS_ID_SIZE) == 0);
+ return strncmp(pdev->name, drv->name,
+ min(BUS_ID_SIZE, strlen(drv->name))) == 0;
}
static int platform_suspend(struct device * dev, pm_message_t state)
next prev parent reply other threads:[~2006-01-06 6:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 5:59 Platform device matching, & weird strncmp usage Benjamin Herrenschmidt
2006-01-06 6:04 ` Benjamin Herrenschmidt [this message]
2006-01-06 18:53 ` Russell King
2006-01-06 21:38 ` Benjamin Herrenschmidt
2006-01-07 19:24 ` Kurtis D. Rader
2006-01-07 19:42 ` Bob Copeland
2006-01-07 22:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1136527457.4840.123.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox