From: Zan Lynx <zlynx@acm.org>
To: Jens Axboe <axboe@suse.de>
Cc: Jesper Juhl <jesper.juhl@gmail.com>,
Khushil Dep <khushil.dep@help.basilica.co.uk>,
Al Viro <viro@ftp.linux.org.uk>,
Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>,
akpm <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bio: gcc warning fix.
Date: Fri, 06 Jan 2006 12:33:56 -0700 [thread overview]
Message-ID: <1136576037.10342.6.camel@localhost> (raw)
In-Reply-To: <20060106184810.GR3389@suse.de>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Fri, 2006-01-06 at 19:48 +0100, Jens Axboe wrote:
> On Fri, Jan 06 2006, Jesper Juhl wrote:
> > gcc is right to warn in the sense that it doesn't know if
> > bvec_alloc_bs() will read or write into idx when its address is passed
>
> The function is right there, on top of bio_alloc_bioset(). It's even
> inlined. gcc has absolutely no reason to complain.
GCC complains because it is possible for that function to return without
ever setting a value into idx. It's the "default" case in the switch.
Of course, if that happens, idx will not be used and so it is not
actually a problem.
--
Zan Lynx <zlynx@acm.org>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-01-06 19:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 15:48 [PATCH] bio: gcc warning fix Khushil Dep
2006-01-06 18:41 ` Jesper Juhl
2006-01-06 18:48 ` Jens Axboe
2006-01-06 18:53 ` Jesper Juhl
2006-01-06 18:58 ` Luiz Fernando Capitulino
2006-01-06 19:04 ` Jens Axboe
2006-01-06 19:05 ` Jesper Juhl
2006-01-06 19:33 ` Zan Lynx [this message]
2006-01-06 19:56 ` Al Viro
2006-01-07 12:22 ` Peter Osterlund
-- strict thread matches above, loose matches on Subject: below --
2006-01-06 15:07 Luiz Fernando Capitulino
2006-01-06 15:28 ` Jens Axboe
2006-01-06 15:39 ` Al Viro
2006-01-06 22:43 ` Daniel Barkalow
2006-01-06 22:52 ` Jesper Juhl
2006-01-06 23:13 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1136576037.10342.6.camel@localhost \
--to=zlynx@acm.org \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=jesper.juhl@gmail.com \
--cc=khushil.dep@help.basilica.co.uk \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox