Re: i2c/ smbus question

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Sun, 2006-01-08 at 11:30 +0100, Jean Delvare wrote:

> The i2c_smbus_write_i2c_block_data wrapper function used to be defined,
> but was removed in 2.6.10-rc2 together with a couple other similar
> wrappers [1] on request by Adrian Bunk, the reason being that they had
> no user back then. I was a bit reluctant at first, but we finally agreed
> with Adrian to remove the functions, and to reintroduce them later if
> they were ever needed.

Argh... Adrian, sometimes I hate you ;-)

> So, if you need i2c_smbus_write_i2c_block_data(), we can easily
> resurrect it. See the patch below. I made the new version a bit faster
> (I hope) than the original by using memcpy, please confirm it works for
> you.

Seems to work. Greg, would you mean boucing that to Linus asap (if you
are ok with it of course) ? I have a pile of patch about to hit him via
the powerpc merge git tree and I'll "fix" some of the mac drivers in
there to use that wrapper, so without that patch, g5 won't build ;)

Thanks !

Ben.