Re: [PATCH 2/2] dasd: remove dynamic ioctl registration

[Martin Schwidefsky <schwidefsky@de.ibm.com>]

On Fri, 2006-01-06 at 09:29 -0500, Ric Wheeler wrote:
> 
> Christoph Hellwig wrote:
> 
> >>If you could hold off just a couple of weeks, I hope that we can get 
> >>through our EMC process junk and get the GPL'ed patch out to fix the 
> >>symmetrix support part of this rolled in as well,
> >>    
> >>
> >
> >Why?  We never do things to support legally questionable binary modules.
> >And on the practical side, does emc even ship modules for -mm release?
> >What's the point of not putting it into -mm?
> >  
> >
> No need for an EMC module, I think that we can issue a simple  patch to 
> dasd.c that removes the (silly) binary module that was there.
> 
> I would prefer that the clean up not break one of the few (and 
> relatively common) devices supported by the dasd.c driver. If for no 
> other reason, it would seem to make it more likely to be able test the 
> existing patch properly.

The patch we got from EMC is for 2.4 and in its current form would never
have worked for 2.6 anyway. So 2.6 is already broken, no reason to hold
off the ioctl removal patch. We'll come up with a cleaned up solution.

Christoph, please go ahead and push the patch to Andrew. 

-- 
blue skies,
   Martin

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH