From: "Bryan O'Sullivan" <bos@pathscale.com>
To: Andi Kleen <ak@suse.de>
Cc: akpm@osdl.org, rdreier@cisco.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64
Date: Wed, 11 Jan 2006 17:27:13 -0800 [thread overview]
Message-ID: <1137029233.17705.46.camel@localhost.localdomain> (raw)
In-Reply-To: <200601120156.11529.ak@suse.de>
On Thu, 2006-01-12 at 01:56 +0100, Andi Kleen wrote:
> At least some people have complained about the "All Rights reserved"
> in the past. Best you drop it.
OK, thanks.
> Usually one should use .p2align or ENTRY() at function beginning,
> otherwise you might get some penalty on K8.
Will do.
> > +__raw_memcpy_toio32:
> > + movl %edx,%ecx
> > + shrl $1,%ecx
>
> 1? If it's called memcpy it should get a byte argument, no? If not
> name it something else, otherwise everybody will be confused.
It's called toio32 for a reason :-)
Also, the kernel doc clearly states its purpose.
> movsq? I thought you wanted 32bit IO?
The northbridge will split qword writes into pairs of dword writes.
> The movsd also looks weird.
Why?
<b
--
Bryan O'Sullivan <bos@pathscale.com>
next prev parent reply other threads:[~2006-01-12 1:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 0:29 [PATCH 0 of 2] Much smaller MMIO copy patches Bryan O'Sullivan
2006-01-12 0:29 ` [PATCH 1 of 2] Introduce __raw_memcpy_toio32 Bryan O'Sullivan
2006-01-12 0:29 ` [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64 Bryan O'Sullivan
2006-01-12 0:56 ` Andi Kleen
2006-01-12 1:21 ` Roland Dreier
2006-01-12 1:27 ` Andi Kleen
2006-01-12 1:32 ` Roland Dreier
2006-01-12 1:40 ` Andi Kleen
2006-01-12 1:27 ` Bryan O'Sullivan [this message]
2006-01-12 1:33 ` Andi Kleen
2006-01-12 4:14 ` Bryan O'Sullivan
2006-01-12 4:19 ` Andi Kleen
2006-01-12 4:32 ` Bryan O'Sullivan
2006-01-12 4:45 ` Andi Kleen
2006-01-12 5:04 ` Bryan O'Sullivan
2006-01-12 15:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137029233.17705.46.camel@localhost.localdomain \
--to=bos@pathscale.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox