From: "Bryan O'Sullivan" <bos@pathscale.com>
To: Andi Kleen <ak@suse.de>
Cc: akpm@osdl.org, rdreier@cisco.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64
Date: Wed, 11 Jan 2006 20:32:40 -0800 [thread overview]
Message-ID: <1137040361.29795.8.camel@camp4.serpentine.com> (raw)
In-Reply-To: <200601120519.12960.ak@suse.de>
On Thu, 2006-01-12 at 05:19 +0100, Andi Kleen wrote:
> My feeling is more and more that this thing is so specialized for your setup
> and so narrow purpose that you're best off dropping this whole patchkit and
> just put the assembly into your driver.
But this gave people fits when Roland first posted the driver for
review. There's also no clean, obvious way to make it work on other
64-bit architectures, in that case.
I don't mind switching the movsq to a movsd, if that's the main aspect
of what you're worried about now, so that it is absolutely a 32-bit
copy.
<b
next prev parent reply other threads:[~2006-01-12 4:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 0:29 [PATCH 0 of 2] Much smaller MMIO copy patches Bryan O'Sullivan
2006-01-12 0:29 ` [PATCH 1 of 2] Introduce __raw_memcpy_toio32 Bryan O'Sullivan
2006-01-12 0:29 ` [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64 Bryan O'Sullivan
2006-01-12 0:56 ` Andi Kleen
2006-01-12 1:21 ` Roland Dreier
2006-01-12 1:27 ` Andi Kleen
2006-01-12 1:32 ` Roland Dreier
2006-01-12 1:40 ` Andi Kleen
2006-01-12 1:27 ` Bryan O'Sullivan
2006-01-12 1:33 ` Andi Kleen
2006-01-12 4:14 ` Bryan O'Sullivan
2006-01-12 4:19 ` Andi Kleen
2006-01-12 4:32 ` Bryan O'Sullivan [this message]
2006-01-12 4:45 ` Andi Kleen
2006-01-12 5:04 ` Bryan O'Sullivan
2006-01-12 15:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137040361.29795.8.camel@camp4.serpentine.com \
--to=bos@pathscale.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox