From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: "Ville Syrjälä" <syrjala@sci.fi>,
"Ondrej Zary" <linux@rainbow-software.org>,
"Robert Hancock" <hancockr@shaw.ca>,
"Volker Kuhlmann" <list0570@paradise.net.nz>,
"Jens Axboe" <axboe@suse.de>,
linux-ide <linux-ide@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fwd: ide-cd turning off DMA when verifying DVD-R
Date: Fri, 13 Jan 2006 14:24:25 +0000 [thread overview]
Message-ID: <1137162265.4419.6.camel@localhost.localdomain> (raw)
In-Reply-To: <58cb370e0601130533n5842cb5fufc5058f9a1acc606@mail.gmail.com>
On Gwe, 2006-01-13 at 14:33 +0100, Bartlomiej Zolnierkiewicz wrote:
> The patch was NACK-ed by Alan Cox and I agree with him (this should be
> done differently). This __ide_dma_off() chunk looks sensible but does it fix
> the issue? I was under impression that after a reset drive looses its DMA
> xfer mode and needs to be reprogrammed (ATA spec has the answer).
Yes and the behaviour is determined by hdparm -k/-K. Its all a bit
random after a CRC error however as the recovery code does a polling
speed change and the locking versus timers/irq's is totally broken.
I did some minimal fixes in the older -ac patches but even with all the
other locking cleanup I did back then this one remained. Essentially the
old IDE layer needs to switch from polled speed changes in task context
to issuing speed changes as state machine sequences.
Thats non trivial
Alan
next prev parent reply other threads:[~2006-01-13 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5ujmU-1UQ-665@gated-at.bofh.it>
[not found] ` <5uoqr-Qq-7@gated-at.bofh.it>
2006-01-13 4:40 ` ide-cd turning off DMA when verifying DVD-R Robert Hancock
2006-01-13 8:30 ` Volker Kuhlmann
2006-01-13 9:19 ` Bartlomiej Zolnierkiewicz
2006-01-13 13:03 ` Ondrej Zary
[not found] ` <58cb370e0601130121s2f6c0a26jda00ff64df197342@mail.gmail.com>
[not found] ` <20060113093818.GA22984@sci.fi>
[not found] ` <58cb370e0601130149g32323b4axbf0ac55f83ac9148@mail.gmail.com>
[not found] ` <20060113112510.GA23264@sci.fi>
2006-01-13 13:33 ` Fwd: " Bartlomiej Zolnierkiewicz
2006-01-13 14:24 ` Alan Cox [this message]
[not found] ` <20060113140618.GB12360@tigershaunt.com>
2006-01-13 14:16 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137162265.4419.6.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=list0570@paradise.net.nz \
--cc=syrjala@sci.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox