From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Calin A. Culianu" <calin@ajvar.org>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
Willy Tarreau <willy@w.ods.org>
Subject: Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC
Date: Sat, 14 Jan 2006 19:24:09 +0000 [thread overview]
Message-ID: <1137266649.23269.2.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0601132149430.9231@rtlab.med.cornell.edu>
Some quick comments:
+ if (len) {
+ epx_c3_pet();
+ }
Doesn't need brackets (minor style)
Otherwise it looks excellent but should use request_region and friends
to claim the two ports it uses.
The see the "Sign your work:" bit of Documentation/SubmittingPatches are
it looks ready to go in.
Alan
next prev parent reply other threads:[~2006-01-14 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-14 2:59 [PATCH] Watchdog: Winsystems EPX-C3 SBC Calin A. Culianu
2006-01-14 19:24 ` Alan Cox [this message]
2006-01-14 20:08 ` Willy Tarreau
2006-01-29 23:47 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137266649.23269.2.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=calin@ajvar.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox