From: Paul Fulghum <paulkf@microgate.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] synclink_gt fix size of register value storage
Date: Tue, 17 Jan 2006 10:35:18 -0600 [thread overview]
Message-ID: <1137515718.3403.5.camel@amdx2.microgate.com> (raw)
Fix incorrect variable size used to hold
register value. This bug might wipe out a portion of the
TCR value when setting the interface options.
Signed-off-by: Paul Fulghum <paulkf@microgate.com>
--- linux-2.6.16-rc1/drivers/char/synclink_gt.c 2006-01-17 09:31:20.000000000 -0600
+++ linux-2.6.16-rc1-mg/drivers/char/synclink_gt.c 2006-01-17 10:22:48.000000000 -0600
@@ -2630,7 +2630,7 @@ static int get_interface(struct slgt_inf
static int set_interface(struct slgt_info *info, int if_mode)
{
unsigned long flags;
- unsigned char val;
+ unsigned short val;
DBGINFO(("%s set_interface=%x)\n", info->device_name, if_mode));
spin_lock_irqsave(&info->lock,flags);
next reply other threads:[~2006-01-17 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 16:35 Paul Fulghum [this message]
2006-01-18 12:03 ` [PATCH] synclink_gt fix size of register value storage Jiri Slaby
2006-01-18 15:28 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137515718.3403.5.camel@amdx2.microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox