From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA8BC43219 for ; Fri, 3 May 2019 19:22:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 550BB2075C for ; Fri, 3 May 2019 19:22:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="oJyLWiZA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726552AbfECTWf (ORCPT ); Fri, 3 May 2019 15:22:35 -0400 Received: from mail.efficios.com ([167.114.142.138]:59300 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbfECTWf (ORCPT ); Fri, 3 May 2019 15:22:35 -0400 Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id 6E86D1DEA36; Fri, 3 May 2019 15:22:33 -0400 (EDT) Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id 0QuwNrTwQwAY; Fri, 3 May 2019 15:22:33 -0400 (EDT) Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id E9E7F1DEA14; Fri, 3 May 2019 15:22:32 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com E9E7F1DEA14 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1556911353; bh=Z1fXbode9z//U9geZ8RU9W20aXBHSnu7pA0JsyOME6U=; h=Date:From:To:Message-ID:MIME-Version; b=oJyLWiZAFwoLwOGgE/MF/ve5CmfrvgRQC3357sjT/Lu+vyPLa4t5XIFPcail2khfE FPuWIFxcT7lRWMYv1LTCAsgWVuzmLi901E1sH/a7YNODtduZGFcJkVqK00NTgq7ysG 5CwtUVbbufy8KEkLSUDax3NDMfTMs3EDN0FZ7eYqFPptZHAqgfpqIPc9yeH6c7rXq9 wHCqgo/7rpLRpgzH6Z+/+VHw/as3wcOATZg/1kAMGmfJx9gEUP5814jnH8UdYq5Xy4 TnPppbgf75vEsavaCGv8GON7R+4IMK5Du7x+4XpbQGztic6wZNUAej7vjHmdVy3Cgv xmltnO/50PLkw== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id zcPuURcV7p-X; Fri, 3 May 2019 15:22:32 -0400 (EDT) Received: from mail02.efficios.com (mail02.efficios.com [167.114.142.138]) by mail.efficios.com (Postfix) with ESMTP id C98851DEA0E; Fri, 3 May 2019 15:22:32 -0400 (EDT) Date: Fri, 3 May 2019 15:22:32 -0400 (EDT) From: Mathieu Desnoyers To: shuah , Andy Whitcroft , Joe Perches Cc: linux-kernel , linux-api , Thomas Gleixner , Peter Zijlstra , "Paul E . McKenney" , Boqun Feng , Andy Lutomirski , Dave Watson , Paul Turner , Andrew Morton , Russell King , Ingo Molnar , "H. Peter Anvin" , Andi Kleen , Chris Lameter , Ben Maurer , rostedt , Josh Triplett , Linus Torvalds , Catalin Marinas , Will Deacon , Michael Kerrisk , Joel Fernandes Message-ID: <1137649333.995.1556911352713.JavaMail.zimbra@efficios.com> In-Reply-To: <68a135d7-7b30-71c7-c570-c7608d6f75d5@kernel.org> References: <20190429152803.7719-1-mathieu.desnoyers@efficios.com> <678952111.699.1556908562445.JavaMail.zimbra@efficios.com> <68a135d7-7b30-71c7-c570-c7608d6f75d5@kernel.org> Subject: Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.142.138] X-Mailer: Zimbra 8.8.12_GA_3794 (ZimbraWebClient - FF66 (Linux)/8.8.12_GA_3794) Thread-Topic: Restartable Sequences selftests updates Thread-Index: nivK8tFeBpLkZ4PuzE/4yflaEoxB+w== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On May 3, 2019, at 2:53 PM, shuah shuah@kernel.org wrote: > On 5/3/19 12:36 PM, Mathieu Desnoyers wrote: >> ----- On Apr 29, 2019, at 11:27 AM, Mathieu Desnoyers >> mathieu.desnoyers@efficios.com wrote: >> >>> Those rseq selftests updates are hereby submitted to Shuah Khan, >>> maintainer of kernel selftests, for the next merge window (5.2). >>> >>> They change the per-architecture pre-abort signatures to ensure those >>> are valid trap instructions. >>> >>> The way exit points are presented to debuggers is enhanced, ensuring >>> all exit points are present, so debuggers don't have to disassemble >>> rseq critical section to properly skip over them. >>> >>> Discussions with the glibc community is reaching a concensus of exposing >>> a __rseq_handled symbol from glibc to coexist with rseq early adopters. >>> Update the rseq selftest code to expose and use this symbol. >>> >>> Support for compiling asm goto with clang is added with the >>> "-no-integrated-as" compiler switch, similarly to the toplevel kernel >>> Makefile. >> >> Hi Shuah, >> >> Is there anything else you need before you can pick up those patches ? >> > > I was going to say "no more work needed" and noticed that the series has > checkpatch errors and warns as I was running the series through > pre-commit tests. > > Patches 1,2,3,8 have errors/warns based > on quick look at the log. > > > ERROR: need consistent spacing around '%' (ctx:WxV) > #227: FILE: tools/testing/selftests/rseq/rseq-x86.h:104: > + RSEQ_ASM_CMP_CPU_ID(cpu_id, RSEQ_CPU_ID_OFFSET(%[rseq_abi]), %l[error1]) > > > Will you be able to fix them and resend? (CCing the che checkpatch maintainers) checkpatch appears to be wrong for these errors. I suspect it thinks those are '%' modulo operators (for which the style requires space before/after), but those are actually part of the asm input and goto target operands. Most warnings are about some lines over 80 cols. However, the areas where this happens is due to following the style of already upstream code which has the final "\" at the end of line sometimes beyond 80 col to accommodate macros that take a bit of horizontal real estate. For patch 8, the warning about "availble" being a typo is right. The style error about space after "asm (" is right as well. Should I send only this updated patch to you or should I send the whole patchset again ? Thanks, Mathieu > > thanks, > -- Shuah -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com