Re: [PATCH 0/5] stack overflow safe kdump (2.6.15-i386)

[Fernando Luis Vazquez Cao <fernando@intellilink.co.jp>]

On Tue, 2006-01-17 at 20:56 -0500, Vivek Goyal wrote:
> On Mon, Jan 16, 2006 at 10:23:15PM +0900, Fernando Luis Vazquez Cao wrote:
> > Hi,
> > 
> > The following set of patches aims at making kdump robust against stack
> > overflows. 
> > 
> > In this new version I tried to incorporate all the ideas received after
> > a previous post. However, there is still room for further improvements
> > some of which I point out below (see "->"). I would appreciate your
> > comments before I start working on them.
> > 
> > This patch set does the following:
> > 
> > * Substitute "smp_processor_id" with the stack overflow-safe
> > "safe_smp_processor_id" in the reboot path to the second kernel.
> > 
> > * Use a private 4K stack for the NMI handler (if CONFIG_4KSTACKS
> > enabled).
> > 
> > * On the event of a system crash:
> >    - Replace NMI trap vector with "crash_nmi".
> >    - Replace NMI handler with "do_crash_nmi".
> > 
> > List of patches (the last two should be applied in the order of
> > appearance):
> > 
> > [1/5] safe_smp_processor_id: Stack overflow safe implementation of
> > smp_processor_id.
> > 
> > [2/5] use_safe_smp_processor_id: Replace smp_processor_id with
> > safe_smp_processor_id in arch/i386/kernel/crash.c.
> > 
> > [3/5] fault: Take stack overflows into account in do_page_fault.
> > 
> > [4/5] nmi_vector: In the nmi path, we have the problem that both nmi_enter and
> > nmi_exit in do_nmi (see code below) make heavy use of "current" indirectly
> > (specially through the kernel preemption code). To avoid this execution path the
> > nmi trap handler is substituted with a stack overflow safe replacement.
> > 
> >    -> Regarding the implementation, I have some doubts:
> >       - Should the NMI vector replaced atomically?
> >       - Should the NMI watchdog be stopped? Should NMIs be disabled in the crash
> >         path of each CPU?
> >       This is important because after replacing the nmi handler the NMI
> >       watchdog will continue generating interrupts that need to be handled
> >       properly. If we can avoid this a kdump-specific nmi vector handler
> >       (ENTRY(crash_nmi)) could be safely used.
> 
> Can we have something like per cpu flag which will be set if NMI is received
> after crash (after replacing the trap vector). If another NMI occurs on 
> the same cpu and if flag is set, return and don't process it further.
The problem is that when one CPU crashes in a SMP system and the NMI
watchdog is enabled, the others will continue receiving NMI from the
watchdog and will eventually also receive the NMI from the crashing CPU.
The NMI handler has to be able to process both adequately if we cannot
stop the NMI watchdog atomically. Even if we used such a flag we would
need to figure out the originator of the NMI.

Regards,

Fernando