public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [PATCH] W1: u64 is not long long
Date: Thu, 19 Jan 2006 22:07:17 -0800	[thread overview]
Message-ID: <1137737237487@kroah.com> (raw)
In-Reply-To: <11377372373543@kroah.com>

[PATCH] W1: u64 is not long long

You don't know what type a u64 is, hence you cannot print it without a cast.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
commit 607d7b2cdf6922fe9f567db52115c62d22ba4925
tree 5d9072e66c18a92c35def2e55c0450c3cb9ef6d7
parent c8d1a16495d65c58ac1454e33b124105db9eb4fd
author Andrew Morton <akpm@osdl.org> Sat, 14 Jan 2006 00:05:59 -0800
committer Greg Kroah-Hartman <gregkh@suse.de> Thu, 19 Jan 2006 21:53:27 -0800

 drivers/w1/w1.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 5def7fb..d640c1e 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -388,11 +388,14 @@ static int w1_uevent(struct device *dev,
 	if (dev->driver != &w1_slave_driver || !sl)
 		return 0;
 
-	err = add_uevent_var(envp, num_envp, &cur_index, buffer, buffer_size, &cur_len, "W1_FID=%02X", sl->reg_num.family);
+	err = add_uevent_var(envp, num_envp, &cur_index, buffer, buffer_size,
+			&cur_len, "W1_FID=%02X", sl->reg_num.family);
 	if (err)
 		return err;
 
-	err = add_uevent_var(envp, num_envp, &cur_index, buffer, buffer_size, &cur_len, "W1_SLAVE_ID=%024LX", (u64)sl->reg_num.id);
+	err = add_uevent_var(envp, num_envp, &cur_index, buffer, buffer_size,
+			&cur_len, "W1_SLAVE_ID=%024LX",
+			(unsigned long long)sl->reg_num.id);
 	if (err)
 		return err;
 


      reply	other threads:[~2006-01-20  6:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <11377372352083@kroah.com>
2006-01-20  6:07 ` [PATCH] W1: Add the DS2482 I2C-to-w1 bridge driver Greg KH
2006-01-20  6:07   ` [PATCH] W1: misc cleanups Greg KH
2006-01-20  6:07     ` [PATCH] W1: fix W1_MASTER_DS9490_BRIDGE dependencies Greg KH
2006-01-20  6:07       ` [PATCH] W1: Remove incorrect MODULE_ALIAS Greg KH
2006-01-20  6:07         ` [PATCH] W1: Change the type 'unsigned long' member of 'struct w1_bus_master' to 'void *' Greg KH
2006-01-20  6:07           ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1137737237487@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox