From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>
Cc: akpm <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>,
arjan@infradead.org
Subject: Re: [PATCH] slab: Adds two missing kmalloc() checks.
Date: Mon, 23 Jan 2006 18:38:36 +0200 [thread overview]
Message-ID: <1138034316.10527.2.camel@localhost> (raw)
In-Reply-To: <20060123133121.70f2cbcb.lcapitulino@mandriva.com.br>
Hi,
On Mon, 2006-01-23 at 13:31 -0200, Luiz Fernando Capitulino wrote:
> Adds two missing kmalloc() checks in kmem_cache_init(). The check is worth
> because if kmalloc() fails we'll have a nice message instead of a OOPS (which
> will make us look for a bug).
>
> We're using BUG_ON() so that embedded people can disable it.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@mandriva.com.br>
Looks good to me. Arjan, you had some objections last time around. Are
you okay with the change?
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Pekka
next prev parent reply other threads:[~2006-01-23 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-23 15:31 [PATCH] slab: Adds two missing kmalloc() checks Luiz Fernando Capitulino
2006-01-23 16:38 ` Pekka Enberg [this message]
2006-01-23 16:44 ` Arjan van de Ven
2006-01-23 16:52 ` Pekka Enberg
2006-01-23 17:01 ` Luiz Fernando Capitulino
2006-01-23 17:06 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138034316.10527.2.camel@localhost \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox