From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RT] possible bug in trace_start_sched_wakeup
Date: Thu, 26 Jan 2006 23:38:38 -0500 [thread overview]
Message-ID: <1138336718.7814.41.camel@localhost.localdomain> (raw)
In-Reply-To: <1138327022.7814.8.camel@localhost.localdomain>
Ingo,
I'm assuming that this was a bug, so I'm patching it. I made it now
test to see if the new process is realtime and higher priority than the
current tracing process to continue.
I'll analyze it more tomorrow (after a few hours of sleep) to see if
this makes sense, as well as hope that you have a comment or two saying
it does, or if it doesn't, to enlighten me to why.
Thanks,
-- Steve
Index: linux-2.6.15-rt15/kernel/latency.c
===================================================================
--- linux-2.6.15-rt15.orig/kernel/latency.c 2006-01-25 17:02:26.000000000 -0500
+++ linux-2.6.15-rt15/kernel/latency.c 2006-01-26 21:03:30.000000000 -0500
@@ -1908,7 +1908,7 @@
return;
spin_lock(&sch.trace_lock);
- if (sch.task && (sch.task->prio >= p->prio))
+ if (sch.task && ((sch.task->prio <= p->prio) || !rt_task(p)))
goto out_unlock;
/*
@@ -1974,7 +1974,7 @@
} else {
if (sch.task)
trace_special_pid(sch.task->pid, sch.task->prio, p->prio);
- if (sch.task && (sch.task->prio >= p->prio))
+ if (sch.task && ((sch.task->prio <= p->prio) || !rt_task(p)))
sch.task = NULL;
spin_unlock(&sch.trace_lock);
}
next prev parent reply other threads:[~2006-01-27 4:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 1:57 [RT] possible bug in trace_start_sched_wakeup Steven Rostedt
2006-01-27 4:38 ` Steven Rostedt [this message]
2006-01-27 9:46 ` Ingo Molnar
2006-01-27 12:46 ` Steven Rostedt
2006-01-27 9:54 ` Ingo Molnar
2006-01-27 12:47 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138336718.7814.41.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox