From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RT] possible bug in trace_start_sched_wakeup
Date: Fri, 27 Jan 2006 07:47:31 -0500 [thread overview]
Message-ID: <1138366051.8988.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20060127095449.GC24878@elte.hu>
On Fri, 2006-01-27 at 10:54 +0100, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > trace_special_pid(sch.task->pid, sch.task->prio, p->prio);
> > - if (sch.task && (sch.task->prio >= p->prio))
> > + if (sch.task && ((sch.task->prio <= p->prio) || !rt_task(p)))
> > sch.task = NULL;
>
> this second condition i'd not change: it just expresses the rare case
> where a higher-prio task hits the CPU that we somehow did not start to
> trace. In that case we just zap the current trace.
>
OK, I think I understand that part now too. There wasn't any comments
about what it was doing so I wasn't sure if that was the right move.
But looking at it further, I believe you are right.
Thanks,
-- Steve
prev parent reply other threads:[~2006-01-27 12:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 1:57 [RT] possible bug in trace_start_sched_wakeup Steven Rostedt
2006-01-27 4:38 ` Steven Rostedt
2006-01-27 9:46 ` Ingo Molnar
2006-01-27 12:46 ` Steven Rostedt
2006-01-27 9:54 ` Ingo Molnar
2006-01-27 12:47 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138366051.8988.3.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox