public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: colpatch@us.ibm.com
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 2/6] Create and Use common mempool allocators
Date: Sat, 28 Jan 2006 12:08:12 +0200	[thread overview]
Message-ID: <1138442892.8657.4.camel@localhost> (raw)
In-Reply-To: <1138407582.26088.2.camel@localhost.localdomain>

Hi,

On Fri, 2006-01-27 at 16:19 -0800, Matthew Dobson wrote:
> -	cc->page_pool = mempool_create(MIN_POOL_PAGES, mempool_alloc_page,
> -				       mempool_free_page, NULL);
> +	cc->page_pool = mempool_create(MIN_POOL_PAGES, mempool_alloc_pages,
> +				       mempool_free_pages, 0);

You need to cast that zero to a void pointer to avoid compliation
warning (found in various other places as well). Would probably make
sense to implement helper functions so the casting doesn't spread all
over the place. Other than that, looks good to me.

			Pekka


  reply	other threads:[~2006-01-28 10:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060128001539.030809000@localhost.localdomain>
2006-01-28  0:19 ` [patch 1/6] Create and Use common mempool allocators Matthew Dobson
2006-01-28  0:19 ` [patch 2/6] " Matthew Dobson
2006-01-28 10:08   ` Pekka Enberg [this message]
2006-01-28  0:19 ` [patch 3/6] " Matthew Dobson
2006-01-28  0:19 ` [patch 4/6] " Matthew Dobson
2006-01-28  0:19 ` [patch 5/6] " Matthew Dobson
2006-01-28  0:20 ` [patch 6/6] " Matthew Dobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1138442892.8657.4.camel@localhost \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@osdl.org \
    --cc=colpatch@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox