From: Janusz Krzysztofik <jmkrzyszt@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Janusz Krzysztofik <jmkrzyszt@gmail.com>
Subject: Re: [RFC PATCH 4/5] media: ov6650: Fix frame scaling not reset on crop
Date: Sun, 02 Jun 2019 11:58:23 +0200 [thread overview]
Message-ID: <11387277.ecJxfdHps5@z50> (raw)
In-Reply-To: <20190601223754.65soglqayxrblgzl@mara.localdomain>
Hi Sakari,
On Sunday, June 2, 2019 12:37:55 AM CEST Sakari Ailus wrote:
>
> ... I realised that the subtle effect of "media:
> ov6650: Register with asynchronous subdevice framework" is that the driver
> is now responsible for serialising the access to its own data structures
> now.
Indeed, I must have been not thinking much while preparing it, only following
patterns from other implementations blindly, sorry.
> And it doesn't do that. Could you submit a fix, please? It'd be good to
> get that to 5.2 through the fixes branch.
How about dropping that V4L2_SUBDEV_FL_HAS_DEVNODE flag for now? I think that
will be the most safe approach for a quick fix. I'd then re-add it together
with proper locking in a separate patch later. What do yo think?
Thanks,
Janusz
next prev parent reply other threads:[~2019-06-02 9:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 20:47 [RFC PATCH 0/5] media: ov6650: V4L2 subdev compliance fixes Janusz Krzysztofik
2019-05-26 20:47 ` [RFC PATCH 1/5] media: ov6650: Fix V4L2_SEL_FLAG_KEEP_CONFIG handling Janusz Krzysztofik
2019-05-26 20:47 ` [RFC PATCH 2/5] media: ov6650: Refactor ov6650_s_fmt() helper Janusz Krzysztofik
2019-05-26 20:47 ` [RFC PATCH 3/5] media: ov6650: Fix active crop rectangle affected by .set_fmt() Janusz Krzysztofik
2019-05-26 20:47 ` [RFC PATCH 4/5] media: ov6650: Fix frame scaling not reset on crop Janusz Krzysztofik
2019-05-31 11:42 ` Sakari Ailus
2019-05-31 17:56 ` Janusz Krzysztofik
2019-06-01 22:37 ` Sakari Ailus
2019-06-02 9:58 ` Janusz Krzysztofik [this message]
2019-06-02 20:36 ` Sakari Ailus
2019-05-26 20:47 ` [RFC PATCH 5/5] media: ov6650: Add .init_cfg() pad operation callback Janusz Krzysztofik
2019-06-01 22:29 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11387277.ecJxfdHps5@z50 \
--to=jmkrzyszt@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox