From: Johannes Berg <johannes@sipsolutions.net>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: Re: [RFC 3/4] firewire: unconditionally export hpsb_send_packet_and_wait
Date: Tue, 07 Feb 2006 11:45:02 +0100 [thread overview]
Message-ID: <1139309102.25972.12.camel@localhost> (raw)
In-Reply-To: <43E600BC.10408@s5r6.in-berlin.de>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Sun, 2006-02-05 at 14:42 +0100, Stefan Richter wrote:
> Leave the export down at the end of ieee1394_core.c among all other
> exports of ieee1394. Just move the export above the #ifdef.
>
> Same for the two new exports by "[RFC 2/4] firewire: dynamic cdev
> allocation below firewire major": Place them at the end of ieee1394_core.c.
Somehow I thought we were supposed to now put the EXPORT_SYMBOL{,_GPL}
right after the declaration. I can post a patch to move all of them
instead just the few if desired, or change this patch.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2006-02-07 13:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-02 22:27 [RFC 0/4] firewire: interface to remote memory (mem1394) Johannes Berg
2006-02-02 22:38 ` [RFC 1/4] firewire: node interface Johannes Berg
2006-02-02 22:40 ` [RFC 2/4] firewire: dynamic cdev allocation below firewire major Johannes Berg
2006-02-05 13:11 ` Stefan Richter
2006-02-13 3:51 ` Jody McIntyre
2006-02-13 7:32 ` Arjan van de Ven
2006-02-13 12:02 ` Johannes Berg
2006-02-13 16:49 ` Stefan Richter
2006-02-13 21:10 ` Arjan van de Ven
2006-02-14 15:41 ` Johannes Berg
2006-02-02 22:41 ` [RFC 3/4] firewire: unconditionally export hpsb_send_packet_and_wait Johannes Berg
2006-02-05 13:42 ` Stefan Richter
2006-02-07 10:45 ` Johannes Berg [this message]
2006-02-02 22:43 ` [RFC 4/4] firewire: add mem1394 Johannes Berg
2006-02-03 11:35 ` Andy Wingo
2006-02-03 11:47 ` Johannes Berg
2006-02-05 12:59 ` Stefan Richter
2006-02-05 8:43 ` Andrew Morton
2006-02-05 9:09 ` Kyle Moffett
[not found] ` <43E5D599.5040503@s5r6.in-berlin.de>
2006-02-05 20:09 ` Stefan Richter
2006-02-05 20:17 ` Andi Kleen
2006-02-05 20:50 ` Stefan Richter
2006-02-06 8:44 ` Andi Kleen
2006-02-05 14:19 ` Stefan Richter
2006-02-07 10:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139309102.25972.12.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).