public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Carsten Paeth <calle@calle.in-berlin.de>
Cc: Armin Schindler <armin@melware.de>, Adrian Bunk <bunk@stusta.de>,
	kai.germaschewski@gmx.de, isdn4linux@listserv.isdn4linux.de,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	kkeil@suse.de
Subject: Re: [2.6 patch] ISDN_CAPI_CAPIFS related cleanups
Date: Sun, 12 Feb 2006 12:36:15 +0100	[thread overview]
Message-ID: <1139744175.5070.6.camel@localhost> (raw)
In-Reply-To: <20060212110903.GD17864@calle.in-berlin.de>

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi Calle,

> I have no problems, when capifs is removed, but the pppdcapiplugin
> has to work without it.
> So if you want to remove capifs make sure pppdcapiplugin is
> working without problems together with udev ...
> 
> I'm too busy to check pppdcapiplugin together with udev ....

I posted this patch some time ago (actually April 2004) which made pppd
wait for the device node to be created before failing. I used it since
then and it still works fine for me.

Regards

Marcel


[-- Attachment #2: patch-pppdcapiplugin-wait-for-dev --]
[-- Type: text/x-patch, Size: 743 bytes --]

Index: capiplugin.c
===================================================================
RCS file: /i4ldev/isdn4k-utils/pppdcapiplugin/capiplugin.c,v
retrieving revision 1.33
diff -u -r1.33 capiplugin.c
--- capiplugin.c	16 Jan 2004 15:27:13 -0000	1.33
+++ capiplugin.c	12 Apr 2004 13:20:50 -0000
@@ -1413,6 +1413,11 @@
 	   fatal("capiplugin: failed to get tty devname - %s (%d)",
 			strerror(serrno), serrno);
 	}
+	retry = 0;
+	while (access(tty, 0) != 0 && (retry++ < 4)) {
+	   dbglog("capiplugin: capitty not available, waiting for device ...");
+	   sleep(1);
+	}
 	if (access(tty, 0) != 0 && errno == ENOENT) {
 	      fatal("capiplugin: tty %s doesn't exist - CAPI Filesystem Support not enabled in kernel or not mounted ?", tty);
 	}

  reply	other threads:[~2006-02-12 11:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-31 21:33 [2.6 patch] ISDN_CAPI_CAPIFS related cleanups Adrian Bunk
2006-01-31 21:44 ` Marcel Holtmann
2006-02-02 21:40   ` Adrian Bunk
2006-02-02 23:57     ` Marcel Holtmann
2006-02-03  8:45       ` Armin Schindler
2006-02-03  8:53         ` Marcel Holtmann
2006-02-03 10:18           ` Armin Schindler
2006-02-03 19:57             ` Marcel Holtmann
2006-02-12 11:09               ` Carsten Paeth
2006-02-12 11:36                 ` Marcel Holtmann [this message]
2006-02-18 15:46                   ` Carsten Paeth
2006-02-01  8:43 ` Armin Schindler
2006-02-01 10:44   ` Adrian Bunk
2006-02-01 11:01     ` Armin Schindler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1139744175.5070.6.camel@localhost \
    --to=marcel@holtmann.org \
    --cc=armin@melware.de \
    --cc=bunk@stusta.de \
    --cc=calle@calle.in-berlin.de \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=kai.germaschewski@gmx.de \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox