From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Deepak R Varma <drv@mailo.com>,
outreachy@lists.linux.dev, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, paskripkin@gmail.com,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com,
saurabh.truth@gmail.com
Subject: Re: [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches
Date: Fri, 21 Oct 2022 07:20:43 +0200 [thread overview]
Message-ID: <113aed11-de11-bf68-1ec1-1b420ff502da@gmail.com> (raw)
In-Reply-To: <cover.1666299151.git.drv@mailo.com>
On 10/20/22 23:26, Deepak R Varma wrote:
> Address different kinds of checkpatch complains for the staging/r8188eu module.
> The patches are required to be applied in sequence.
>
> Changes in v4:
> 1. Include patch 11 in the set for unused macro clean up. Suggested by julia.lawall@inria.fr
> 2. Update patch 1 per feedback from David.Laight@ACULAB.COM
> 3. Update patch 5 & 6 per feedback from dan.carpenter@oracle.com & julia.lawall@inria.fr
>
> Changes in v3:
> 1. Patch 4: Extend the __constant_htons to htons change to other files of the driver.
> This was suggested by philipp.g.hortmann@gmail.com
> 2. Patch 4: Spelling mistake corrected as pointed out by joe@perches.com
> 3. Patch 5 through 10: Included in this version. Additional clean up patches.
>
> Changes in v2:
> I incorrectly labeled the first revision as v1 instead of v2. So,
> following change recorded under v1 is actually changes for v2. Feedback
> provided by philipp.g.hortmann@gmail.com
> 1. Improve language / grammar for the patch descriptions
> 2. Further improve code reformatting
>
>
> Deepak R Varma (11):
> staging: r8188eu: use Linux kernel variable naming convention
> staging: r8188eu: reformat long computation lines
> staging: r8188eu: remove {} for single statement blocks
> staging: r8188eu: use htons macro instead of __constant_htons
> staging: r8188eu: correct misspelled words in comments
> staging: r8188eu: Add space between function & macro parameters
> staging: r8188eu: Associate pointer symbol with parameter name
> staging: r8188eu: replace leading spaces by tabs
> staging: r8188eu: Put '{" on the symbol declaration line
> staging: r8188eu: Correct missing or extra space in the statements
> staging: r8188eu: Remove unused macros
>
> drivers/staging/r8188eu/core/rtw_br_ext.c | 119 +++++++++---------
> drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 36 +++---
> drivers/staging/r8188eu/core/rtw_recv.c | 8 +-
> drivers/staging/r8188eu/core/rtw_xmit.c | 14 +--
> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 2 +-
> drivers/staging/r8188eu/hal/odm_RTL8188E.c | 2 +-
> .../staging/r8188eu/hal/rtl8188e_hal_init.c | 2 +-
> drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 16 +--
> .../staging/r8188eu/include/Hal8188EPhyReg.h | 4 +-
> .../staging/r8188eu/include/osdep_service.h | 4 +-
> .../staging/r8188eu/include/rtl8188e_hal.h | 6 +-
> .../staging/r8188eu/include/rtl8188e_spec.h | 18 +--
> drivers/staging/r8188eu/include/rtw_cmd.h | 62 +++++----
> drivers/staging/r8188eu/include/rtw_io.h | 16 +--
> .../staging/r8188eu/include/rtw_ioctl_set.h | 4 +-
> drivers/staging/r8188eu/include/rtw_mlme.h | 22 ++--
> .../staging/r8188eu/include/rtw_mlme_ext.h | 12 +-
> drivers/staging/r8188eu/include/rtw_recv.h | 4 +-
> drivers/staging/r8188eu/include/rtw_xmit.h | 2 +-
> drivers/staging/r8188eu/include/wifi.h | 12 +-
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 6 +-
> 22 files changed, 176 insertions(+), 197 deletions(-)
>
> --
> 2.30.2
>
>
>
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
next prev parent reply other threads:[~2022-10-21 5:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 21:26 [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches Deepak R Varma
2022-10-20 21:26 ` [PATCH v4 01/11] staging: r8188eu: use Linux kernel variable naming convention Deepak R Varma
2022-10-20 21:27 ` [PATCH v4 02/11] staging: r8188eu: reformat long computation lines Deepak R Varma
2022-10-20 21:27 ` [PATCH v4 03/11] staging: r8188eu: remove {} for single statement blocks Deepak R Varma
2022-10-20 21:28 ` [PATCH v4 04/11] staging: r8188eu: use htons macro instead of __constant_htons Deepak R Varma
2022-10-20 21:29 ` [PATCH v4 05/11] staging: r8188eu: correct misspelled words in comments Deepak R Varma
2022-10-20 21:30 ` [PATCH v4 06/11] staging: r8188eu: Add space between function & macro parameters Deepak R Varma
2022-10-20 21:30 ` [PATCH v4 07/11] staging: r8188eu: Associate pointer symbol with parameter name Deepak R Varma
2022-10-20 21:31 ` [PATCH v4 08/11] staging: r8188eu: replace leading spaces by tabs Deepak R Varma
2022-10-21 5:34 ` Praveen Kumar
2022-10-20 23:31 ` Deepak R Varma
2022-10-20 21:31 ` [PATCH v4 09/11] staging: r8188eu: Put '{" on the symbol declaration line Deepak R Varma
2022-10-20 21:32 ` [PATCH v4 10/11] staging: r8188eu: Correct missing or extra space in the statements Deepak R Varma
2022-10-20 21:32 ` [PATCH v4 11/11] staging: r8188eu: Remove unused macros Deepak R Varma
2022-10-21 5:51 ` Praveen Kumar
2022-10-21 5:56 ` Greg KH
2022-10-20 23:34 ` Deepak R Varma
2022-10-21 8:33 ` Greg KH
2022-10-20 23:50 ` Deepak R Varma
2022-10-21 5:20 ` Philipp Hortmann [this message]
2022-10-22 8:05 ` [PATCH v4 00/11] staging: r8188eu: trivial code cleanup patches Greg KH
2022-10-21 16:49 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=113aed11-de11-bf68-1ec1-1b420ff502da@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox