From: Christian Eggers <ceggers@arri.de>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Rob Herring <robh+dt@kernel.org>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>,
George McCollister <george.mccollister@gmail.com>,
Marek Vasut <marex@denx.de>,
Helmut Grohne <helmut.grohne@intenta.de>,
Paul Barker <pbarker@konsulko.com>,
"Codrin Ciubotariu" <codrin.ciubotariu@microchip.com>,
Tristram Ha <Tristram.Ha@microchip.com>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support
Date: Thu, 3 Dec 2020 16:36:26 +0100 [thread overview]
Message-ID: <11406377.LS7tM95F4J@n95hx1g2> (raw)
In-Reply-To: <20201203141255.GF4734@hoboy.vegasvil.org>
On Thursday, 3 December 2020, 15:12:55 CET, Richard Cochran wrote:
> On Thu, Dec 03, 2020 at 11:21:17AM +0100, Christian Eggers wrote:
> > The KSZ9563 has a Trigger Output Unit (TOU) which can be used to
> > generate periodic signals.
> >
> > The pulse length can be altered via a device attribute.
>
> Device tree is the wrong place for that.
I meant a device specfic sysfs attribute.
/sys/class/ptp/ptp2/device/pulse
But this is not true anymore, as I moved the sysfs attribute to a later
patch (not submitted yet).
> Aren't you using PTP_PEROUT_DUTY_CYCLE anyhow?
I also use PTP_PEROUT_DUTY_CYCLE. But this cannot be set via a shell
script. The existing "period" sysfs attribute doesn't allow to set
the pulse length, so I added a device specific attribute for this.
Should ptp_sysfs be extended with a "pulse" attribute with calls
enable() with only PTP_PEROUT_DUTY_CYCLE set?
>
> Thanks,
> Richard
>
>
regards
Christian
next prev parent reply other threads:[~2020-12-03 15:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 10:21 [PATCH net-next v5 0/9] net: dsa: microchip: PTP support for KSZ956x Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 1/9] net: dsa: microchip: rename ksz9477.c to ksz9477_main.c Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 2/9] dt-bindings: net: dsa: microchip,ksz: add interrupt property Christian Eggers
2020-12-09 20:09 ` Rob Herring
2020-12-03 10:21 ` [PATCH net-next v5 3/9] net: dsa: microchip: ksz9477: move chip reset to ksz9477_switch_init() Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 4/9] net: dsa: microchip: ksz9477: basic interrupt support Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 5/9] net: dsa: microchip: ksz9477: add Posix clock support for chip PTP clock Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 6/9] net: ptp: add helper for one-step P2P clocks Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 7/9] net: dsa: microchip: ksz9477: initial hardware time stamping support Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 8/9] net: dsa: microchip: ksz9477: remaining " Christian Eggers
2020-12-03 10:21 ` [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support Christian Eggers
2020-12-03 14:12 ` Richard Cochran
2020-12-03 15:36 ` Christian Eggers [this message]
2020-12-03 15:52 ` Vladimir Oltean
2020-12-03 16:20 ` Christian Eggers
2020-12-04 0:45 ` Richard Cochran
2020-12-04 1:00 ` Vladimir Oltean
2020-12-04 1:18 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11406377.LS7tM95F4J@n95hx1g2 \
--to=ceggers@arri.de \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=codrin.ciubotariu@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=george.mccollister@gmail.com \
--cc=helmut.grohne@intenta.de \
--cc=kuba@kernel.org \
--cc=kurt.kanzenbach@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pbarker@konsulko.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox