From: Richard Purdie <rpurdie@rpsys.net>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Dmitry Torokhov <dtor_core@ameritech.net>,
linux-input@atrey.karlin.mff.cuni.cz,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] zaurus keyboard driver updates
Date: Sun, 05 Mar 2006 09:47:55 +0000 [thread overview]
Message-ID: <1141552075.6521.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20060305080924.GA7145@flint.arm.linux.org.uk>
On Sun, 2006-03-05 at 08:09 +0000, Russell King wrote:
> On Sun, Mar 05, 2006 at 12:06:05AM +0000, Richard Purdie wrote:
> > + request_irq(SPITZ_IRQ_GPIO_AK_INT, spitzkbd_hinge_isr,
> > + SA_INTERRUPT, | SA_TRIGGER_RISING | SA_TRIGGER_FALLING,
>
> This looks bogus (and unbuildable).
Thanks for spotting. The changes have been tested against older kernels
(2.6.15) and the corgi changes against current git but I messed up when
updating the spitz changes.
Richard
prev parent reply other threads:[~2006-03-05 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-05 0:06 [patch] zaurus keyboard driver updates Richard Purdie
2006-03-05 8:09 ` Russell King
2006-03-05 9:47 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141552075.6521.3.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=dtor_core@ameritech.net \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox