From: Richard Purdie <rpurdie@rpsys.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@osdl.org>,
lenz@cs.wisc.edu, kernel list <linux-kernel@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: [patch] fix hardcoded values in collie frontlight
Date: Sun, 05 Mar 2006 19:46:04 +0000 [thread overview]
Message-ID: <1141587964.6521.55.camel@localhost.localdomain> (raw)
In-Reply-To: <20060305142859.GA21173@elf.ucw.cz>
On Sun, 2006-03-05 at 15:28 +0100, Pavel Machek wrote:
> In frontlight support, we should really use values from flash-ROM
> instead of hardcoding our own.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> diff --git a/drivers/video/backlight/locomolcd.c b/drivers/video/backlight/locomolcd.c
> index ada6e75..2bcff84 100644
> --- a/drivers/video/backlight/locomolcd.c
> +++ b/drivers/video/backlight/locomolcd.c
> @@ -27,7 +28,7 @@
> #include <asm/arch/poodle.h>
> #endif
>
> -extern void (*sa1100fb_lcd_power)(int on);
> +#include "../../../arch/arm/mach-sa1100/generic.h"
This would be neater if that was in some more accessible header in
asm/arch. I'm not sure which header that would be though. Russell?
> @@ -93,11 +94,13 @@ void locomolcd_power(int on)
> }
>
> /* read comadj */
> + if (comadj == -1) {
> #ifdef CONFIG_MACH_POODLE
> - comadj = 118;
> + comadj = 118;
> #else
> - comadj = 128;
> + comadj = 128;
> #endif
> + }
Perhaps use machine_is_poodle() and machine_is_collie() here?
I agree with the changes in principle though.
Richard
next prev parent reply other threads:[~2006-03-05 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-05 14:28 [patch] fix hardcoded values in collie frontlight Pavel Machek
2006-03-05 19:46 ` Richard Purdie [this message]
2006-03-06 11:56 ` Pavel Machek
2006-03-06 11:57 ` Pavel Machek
2006-03-06 17:10 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141587964.6521.55.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=akpm@osdl.org \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox