public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: rmk@arm.linux.org.uk
Subject: [Patch] Dead code in mtd/maps/pci.c
Date: Tue, 07 Mar 2006 21:12:35 +0100	[thread overview]
Message-ID: <1141762355.8065.3.camel@alice> (raw)

hi,

this fixed coverity bug #12. The first two gotos
in the function still have the initial value for mtd set.
And the third goto just triggers for !mtd

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.16-rc5-mm1/drivers/mtd/maps/pci.c.orig	2006-03-07 21:08:08.000000000 +0100
+++ linux-2.6.16-rc5-mm1/drivers/mtd/maps/pci.c	2006-03-07 21:08:23.000000000 +0100
@@ -334,9 +334,6 @@ mtd_pci_probe(struct pci_dev *dev, const
 	return 0;
 
 release:
-	if (mtd)
-		map_destroy(mtd);
-
 	if (map) {
 		map->exit(dev, map);
 		kfree(map);



                 reply	other threads:[~2006-03-07 20:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1141762355.8065.3.camel@alice \
    --to=snakebyte@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox