From: "Bryan O'Sullivan" <bos@pathscale.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: rolandd@cisco.com, gregkh@suse.de, akpm@osdl.org,
davem@davemloft.net, linux-kernel@vger.kernel.org,
openib-general@openib.org
Subject: Re: [PATCH 7 of 20] ipath - misc driver support code
Date: Thu, 09 Mar 2006 15:29:02 -0800 [thread overview]
Message-ID: <1141946942.10693.36.camel@serpentine.pathscale.com> (raw)
In-Reply-To: <adau0a7fbzf.fsf@cisco.com>
On Thu, 2006-03-09 at 15:13 -0800, Roland Dreier wrote:
> This is kind of theoritical, but it seems to me that it would be safer
> to write this as
>
> int ipath_unordered_wc(void)
> {
> return boot_cpu_data.x86_vendor != X86_VENDOR_AMD;
> }
>
> after all, Via is probably going to have an x86-64 CPU one of these
> days, and I doubt you've checked that their WC flush is ordered.
It's purely a performance optimisation. Since we tune very closely to
each CPU, there's no point right now in sort-of-tuning for a CPU that
doesn't yet exist :-)
<b
next prev parent reply other threads:[~2006-03-09 23:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2f16f504dd4b98c2ce7c.1141922820@localhost.localdomain>
2006-03-09 23:11 ` [PATCH 7 of 20] ipath - misc driver support code Roland Dreier
2006-03-09 23:27 ` Bryan O'Sullivan
2006-03-09 23:13 ` Roland Dreier
2006-03-09 23:29 ` Bryan O'Sullivan [this message]
2006-03-09 23:36 ` Roland Dreier
2006-03-10 19:23 ` Bryan O'Sullivan
2006-03-10 0:35 [PATCH 0 of 20] [RFC] ipath driver - another round for review Bryan O'Sullivan
2006-03-10 0:35 ` [PATCH 7 of 20] ipath - misc driver support code Bryan O'Sullivan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141946942.10693.36.camel@serpentine.pathscale.com \
--to=bos@pathscale.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox