Re: [UPDATED PATCH] Re: [Lse-tech] Re: [Patch 7/7] Generic netlink interface (delay accounting)

Shailabh Nagar
2006-03-09T16:06:47Z

Balbir Singh wrote:

<snip>

>Hello, Jamal,
>
>Please find the latest version of the patch for review. The genetlink
>code has been updated as per your review comments. The changelog is provided
>below
>
>1. Eliminated TASKSTATS_CMD_LISTEN and TASKSTATS_CMD_IGNORE
>2. Provide generic functions called genlmsg_data() and genlmsg_len()
> in linux/net/genetlink.h
>
>
Balbir,
it might be a good idea to split 2. out separately, since it has generic
value beyond the
delay accounting patches (just like we did for the timespec_diff_ns change)

Thanks,
Shailabh

>3. Do not multicast all replies, multicast only events generated due
> to task exit.
>4. The taskstats and taskstats_reply structures are now 64 bit aligned.
>5. Family id is dynamically generated.
>
>Please let us know if we missed something out.
>
>Thanks,
>Balbir
>
>
>Signed-off-by: Shailabh Nagar <nagar@watson.ibm.com>
>Signed-off-by: Balbir Singh <balbir@in.ibm.com>
>
>---
>
> include/linux/delayacct.h | 2
> include/linux/taskstats.h | 128 ++++++++++++++++++++++++
> include/net/genetlink.h | 20 +++
> init/Kconfig | 16 ++-
> kernel/Makefile | 1
> kernel/delayacct.c | 56 ++++++++++
> kernel/taskstats.c | 244 ++++++++++++++++++++++++++++++++++++++++++++++
> 7 files changed, 464 insertions(+), 3 deletions(-)
>
>
>
<snip>