public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@osdl.org>
Subject: [2.6.16-rc6 patch] remove sleep_avg multiplier
Date: Tue, 14 Mar 2006 10:51:01 +0100	[thread overview]
Message-ID: <1142329861.9710.16.camel@homer> (raw)

Greetings,

The patchlet below removes the sleep_avg multiplier.  This multiplier
was necessary back when we had 10 seconds of dynamic range in sleep_avg,
but now that we only have one second, it causes that one second to be
compressed down to 100ms in some cases.  This is particularly noticeable
when compiling a kernel in a slow NFS mount, and I believe it to be a
very likely candidate for other recently reported network related
interactivity problems.

In testing, I can detect no negative impact of this removal.  IMHO, this
constitutes a bug-fix, and as such is suitable for 2.6.16.

	-Mike

Signed-off-by: Mike Galbraith <efault@gmx.de>

--- linux-2.6.16rc6/kernel/sched.c.org	2006-03-14 10:30:35.000000000 +0100
+++ linux-2.6.16rc6/kernel/sched.c	2006-03-14 10:31:13.000000000 +0100
@@ -707,12 +707,6 @@
 						DEF_TIMESLICE);
 		} else {
 			/*
-			 * The lower the sleep avg a task has the more
-			 * rapidly it will rise with sleep time.
-			 */
-			sleep_time *= (MAX_BONUS - CURRENT_BONUS(p)) ? : 1;
-
-			/*
 			 * Tasks waking from uninterruptible sleep are
 			 * limited in their sleep_avg rise as they
 			 * are likely to be waiting on I/O



             reply	other threads:[~2006-03-14  9:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-14  9:51 Mike Galbraith [this message]
2006-03-14  9:56 ` [2.6.16-rc6 patch] remove sleep_avg multiplier Ingo Molnar
2006-03-14 10:05   ` Con Kolivas
2006-03-14 10:10     ` Con Kolivas
2006-03-14 11:56       ` Mike Galbraith
2006-03-14 12:07         ` Con Kolivas
2006-03-14 12:24           ` Mike Galbraith
2006-03-14 12:29             ` Con Kolivas
2006-03-14 12:36               ` Con Kolivas
2006-03-14 12:40               ` Mike Galbraith
2006-03-14 12:47                 ` Con Kolivas
2006-03-14 12:59                   ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1142329861.9710.16.camel@homer \
    --to=efault@gmx.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox